From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH 05/11] net/sfc: add flow API filters support
Date: Thu, 9 Mar 2017 18:29:03 +0300
Message-ID: <92ac134b-28f5-27b0-bbd4-73b2d0908c0e@solarflare.com>
References: <1488470591-5853-1-git-send-email-arybchenko@solarflare.com>
 <1488470591-5853-6-git-send-email-arybchenko@solarflare.com>
 <070b835f-918d-da6a-8aef-a658606e066a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from nbfkord-smmo03.seg.att.com (nbfkord-smmo03.seg.att.com
 [209.65.160.84]) by dpdk.org (Postfix) with ESMTP id 657BACF9E
 for <dev@dpdk.org>; Thu,  9 Mar 2017 16:29:15 +0100 (CET)
In-Reply-To: <070b835f-918d-da6a-8aef-a658606e066a@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/07/2017 04:21 PM, Ferruh Yigit wrote:
> On 3/2/2017 4:03 PM, Andrew Rybchenko wrote:
>> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>>
>> Only pattern items VOID, ETH and actions VOID, QUEUE is now
>> supported.
>>
>> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> <...>
>
>> diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
>> new file mode 100644
>> index 0000000..0590756
>> --- /dev/null
>> +++ b/drivers/net/sfc/sfc_flow.c
>> @@ -0,0 +1,693 @@
>> +/*-
>> + * Copyright (c) 2017 Solarflare Communications Inc.
>> + * All rights reserved.
> Missing "BSD LICENSE" line. This is same for all new files.
> I think this discussed before, I don't know if that line is mandatory,
> but can be good to have at least to be consistent to rest of the codes.

Since it is common for all our files, let me address is separately.

Thanks,
Andrew.