From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx
	adapter
Date: Mon, 25 Sep 2017 08:29:10 +0530
Message-ID: <92c090c8-b024-dc9f-6d76-59d4b44ab3f5@intel.com>
References: <1506028634-22998-1-git-send-email-nikhil.rao@intel.com>
 <1506028634-22998-4-git-send-email-nikhil.rao@intel.com>
 <20170922091032.GA5895@jerin>
 <da6f07ac-9e60-40c5-0d8b-e85221c1eefd@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org,
 thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com,
 nipun.gupta@nxp.com, narender.vangati@intel.com, erik.g.carrillo@intel.com,
 abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id C151623A
 for <dev@dpdk.org>; Mon, 25 Sep 2017 04:59:16 +0200 (CEST)
In-Reply-To: <da6f07ac-9e60-40c5-0d8b-e85221c1eefd@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/24/2017 11:46 PM, Rao, Nikhil wrote:
> On 9/22/2017 2:40 PM, Jerin Jacob wrote:
>
>> When we worked on a prototype, we figured out that we need a separate 
>> event type
>> for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER?
>> The Reason is:
>> - In the HW based Rx adapter case, the packet are coming directly to 
>> eventdev once it is configured.
>> - So on a HW implementation of the event dequeue(), CPU needs to 
>> convert HW specific
>> metadata to mbuf
>> - The event dequeue() is used in two cases
>> a) octeontx eventdev driver used with any external NIC
>> b) octeontx eventdev driver used with integrated NIC(without service
>> core to inject the packet)
>> We need some identifier to understand case (a) and (b).So, in 
>> dequeue(), if the
>> packet is from RTE_EVENT_TYPE_ETHDEV then we can do "HW specific 
>> metadata" to mbuf
>> conversion and in another case (!RTE_EVENT_TYPE_ETHDEV) result in no mbuf
>> conversion.
>>
>> Application can check if it is an Ethernet type event by
>> ev.event_type == RTE_EVENT_TYPE_ETHDEV || ev.event_type ==
>> RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER
>>
> 
> As per my understanding, the case (a) uses an in built port
> Is it possible for the eventdev PMD to do the conversion based off the 
> eventdev port ?
> 

I realized the dequeue wouldn't have knowledge of the port the event was 
injected from, the application shouldn't have to see the difference 
between case (a) & (b).

Would it be possible to use the impl_opaque field within struct rte_event ?

Nikhil