From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3 00/68] Memory Hotplug for DPDK Date: Fri, 6 Apr 2018 13:55:28 +0100 Message-ID: <92d1db12-87f2-9d1a-b3c6-faa92555c6bc@intel.com> References: <49bcdac0-2631-361d-c454-088c5c70f6b1@nxp.com> <2771974.P4zNJljvph@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "keith.wiles@intel.com" , "jianfeng.tan@intel.com" , "andras.kovacs@ericsson.com" , "laszlo.vadkeri@ericsson.com" , "benjamin.walker@intel.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "kuralamudhan.ramakrishnan@intel.com" , "louise.m.daly@intel.com" , "nelio.laranjeiro@6wind.com" , "yskoh@mellanox.com" , "pepperjo@japf.ch" , "jerin.jacob@caviumnetworks.com" , "olivier.matz@6wind.com" , "gowrishankar.m@linux.vnet.ibm.com" , Thomas Monjalon , Shreyansh Jain Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1570B1D041 for ; Fri, 6 Apr 2018 14:55:39 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06-Apr-18 1:01 PM, Hemant Agrawal wrote: > Hi Thomas > >>> -----Original Message----- >>> From: Thomas Monjalon [mailto:thomas@monjalon.net] >>> Sent: Thursday, April 05, 2018 7:43 PM >>> To: Shreyansh Jain >>> Cc: Anatoly Burakov ; dev@dpdk.org; >>> keith.wiles@intel.com; jianfeng.tan@intel.com; >>> andras.kovacs@ericsson.com; laszlo.vadkeri@ericsson.com; >>> benjamin.walker@intel.com; bruce.richardson@intel.com; >>> konstantin.ananyev@intel.com; kuralamudhan.ramakrishnan@intel.com; >>> louise.m.daly@intel.com; nelio.laranjeiro@6wind.com; >>> yskoh@mellanox.com; pepperjo@japf.ch; jerin.jacob@caviumnetworks.com; >>> Hemant Agrawal ; olivier.matz@6wind.com; >>> gowrishankar.m@linux.vnet.ibm.com >>> Subject: Re: [dpdk-dev] [PATCH v3 00/68] Memory Hotplug for DPDK >>> Importance: High >>> >>> 05/04/2018 16:24, Shreyansh Jain: >>>> Physical addressing cases for both, dpaa/dpaa2, depend heavily on >>>> the fact that physical addressing was the base and was available in >>>> sorted manner. This is reversed/negated with hotplugging support. >>>> So, rework of both the drivers is required from this perspective. >>>> There are some suggestions floated by Anatoly and internally, but >>>> work still needs to be done. >>>> It also impacts a lot of use-cases for virtualization (no-iommu). >>> >>> So what is your recommendation? >>> Can you rework PA case in dpaa/dpaa2 drivers within 18.05 timeframe? >>> >> We will like 2-3 more days on this before we can ack/nack this patch. >> We are working on priority on this. PA case rework is not a trivial change. > > The patch is good to go. However, we will be making changes in dpaa/dpaa2 drivers to fix the PA issues shortly (within 18.05 timeframe) That's great to hear! > > Anatoly needs to take care of following: > 1. Comment by Shreyansh on " Re: [dpdk-dev] [PATCH v3 50/68] eal: replace memzone array with fbarray" Yes, that is already fixed in both github and upcoming v4. > 2. I could not apply the patches cleanly on current master. The patchset has dependencies, listed in the cover letter. I'll rebase on latest master before sending v4 just in case. > > Tested-by: Hemant Agrawal > >> Regards, >> Hemant >> > > -- Thanks, Anatoly