From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/3] kasumi: add new KASUMI PMD Date: Wed, 06 Jul 2016 15:07:59 +0200 Message-ID: <9350149.Sei8q3Fe4Z@xps13> References: <1466159565-27950-1-git-send-email-pablo.de.lara.guarch@intel.com> <1466433606-27398-2-git-send-email-pablo.de.lara.guarch@intel.com> <577CEAD7.4050405@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Pablo de Lara , declan.doherty@intel.com, deepak.k.jain@intel.com, reshma.pattan@intel.com To: Ferruh Yigit Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id A582E6CBC for ; Wed, 6 Jul 2016 15:08:01 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id r201so192025610wme.1 for ; Wed, 06 Jul 2016 06:08:01 -0700 (PDT) In-Reply-To: <577CEAD7.4050405@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-06 12:26, Ferruh Yigit: > On 6/20/2016 3:40 PM, Pablo de Lara wrote: > > enum rte_cryptodev_type { > > RTE_CRYPTODEV_NULL_PMD = 1, /**< Null crypto PMD */ > > RTE_CRYPTODEV_AESNI_GCM_PMD, /**< AES-NI GCM PMD */ > > RTE_CRYPTODEV_AESNI_MB_PMD, /**< AES-NI multi buffer PMD */ > > + RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ > Does adding new field into middle cause a ABI breakage? > Since now value of below fields changed. > > Btw, librte_cryptodev is not listed in release notes, "shared library > versions" section, not sure if this is intentional. Good catch! Now that crypto is not experimental anymore, we must add cryptodev in release notes. librte_pdump is also missing in this list.