From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 2/8] net/ice: add pointer for queue buffer
 release
Date: Fri, 15 Mar 2019 17:52:58 +0000
Message-ID: <93d6786e-925d-5b8b-5125-b0dc556bf098@intel.com>
References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>
 <1552630975-62900-1-git-send-email-wenzhuo.lu@intel.com>
 <1552630975-62900-3-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9F06E2C17
 for <dev@dpdk.org>; Fri, 15 Mar 2019 18:53:00 +0100 (CET)
In-Reply-To: <1552630975-62900-3-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:
> Add function pointers of buffer releasing for RX and
> TX queues, for vector functions will be added for RX
> and TX.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

<...>

> @@ -27,6 +27,9 @@
>  
>  #define ICE_SUPPORT_CHAIN_NUM 5
>  
> +typedef void (*ice_rx_release_mbufs)(struct ice_rx_queue *rxq);
> +typedef void (*ice_tx_release_mbufs)(struct ice_tx_queue *txq);
> +
>  struct ice_rx_entry {
>  	struct rte_mbuf *mbuf;
>  };
> @@ -61,6 +64,7 @@ struct ice_rx_queue {
>  	uint16_t max_pkt_len; /* Maximum packet length */
>  	bool q_set; /* indicate if rx queue has been configured */
>  	bool rx_deferred_start; /* don't start this queue in dev start */
> +	ice_rx_release_mbufs rx_rel_mbufs;
>  };
>  
>  struct ice_tx_entry {
> @@ -100,6 +104,7 @@ struct ice_tx_queue {
>  	uint16_t tx_next_rs;
>  	bool tx_deferred_start; /* don't start this queue in dev start */
>  	bool q_set; /* indicate if tx queue has been configured */
> +	ice_tx_release_mbufs tx_rel_mbufs;

We are not using suffixes as coding convention, and indeed it says "Avoid
typedefs ending in _t" explicitly, but for this case it is not clear that they
are function pointers.

So what do you think either appending a _t suffix, or putting verb to the end to
more sound like function more than object:
ice_tx_mbufs_release_t