From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Reshma Pattan <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 1/3] librte_reorder: New reorder library
Date: Tue, 20 Jan 2015 09:00:38 +0100 [thread overview]
Message-ID: <9416100.1lhCgRCuAQ@xps13> (raw)
In-Reply-To: <1420648753-17136-1-git-send-email-reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi,
2015-01-07 16:39, Reshma Pattan:
> 1)New library to provide reordering of out of ordered
> mbufs based on sequence number of mbuf. Library uses reorder buffer structure
> which in tern uses two circular buffers called ready and order buffers.
> *rte_reorder_create API creates instance of reorder buffer.
> *rte_reorder_init API initializes given reorder buffer instance.
> *rte_reorder_reset API resets given reorder buffer instance.
> *rte_reorder_insert API inserts the mbuf into order circular buffer.
> *rte_reorder_fill_overflow moves mbufs from order buffer to ready buffer
> to accomodate early packets in order buffer.
> *rte_reorder_drain API provides draining facility to fetch out
> reordered mbufs from order and ready buffers.
>
> Signed-off-by: Reshma Pattan <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Richardson Bruce <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
I think 2 things are missing in this patchset:
1) Could you show some performance numbers to compare a simple forwarding
with and without this library, in the commit log?
2) Could you add some documentation in doc/ directory for programmer's guide?
Thank you
--
Thomas
next prev parent reply other threads:[~2015-01-20 8:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 16:39 [PATCH 1/3] librte_reorder: New reorder library Reshma Pattan
[not found] ` <1420648753-17136-1-git-send-email-reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-07 16:39 ` [PATCH 2/3] librte_reorder: New unit test cases added Reshma Pattan
2015-01-07 16:39 ` [PATCH 3/3] librte_reorder: New sample app for reorder library Reshma Pattan
2015-01-07 17:45 ` [PATCH 1/3] librte_reorder: New " Neil Horman
[not found] ` <20150107174509.GC16558-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-08 14:41 ` Pattan, Reshma
2015-01-07 21:09 ` Richard Sanger
[not found] ` <CAN6QFNy1v80NUQTvRZm-w9KeVEzdDZKJMJPt27oC=8QUywY9bQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-08 16:28 ` Pattan, Reshma
2015-01-20 8:00 ` Thomas Monjalon [this message]
2015-01-29 17:35 ` Gonzalez Monroy, Sergio
[not found] ` <91383E96CE459D47BCE92EFBF5CE73B004F43DE1-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-29 20:39 ` Neil Horman
[not found] ` <20150129203936.GH1999-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-30 9:35 ` Gonzalez Monroy, Sergio
2015-01-30 13:14 ` [PATCH v2 0/4] New Reorder Library Sergio Gonzalez Monroy
[not found] ` <1422623694-6430-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-30 13:14 ` [PATCH v2 1/4] reorder: new reorder library Sergio Gonzalez Monroy
2015-01-30 13:14 ` [PATCH v2 2/4] app: New reorder unit test Sergio Gonzalez Monroy
2015-01-30 13:14 ` [PATCH v2 3/4] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-01-30 13:14 ` [PATCH v2 4/4] doc: new reorder library description Sergio Gonzalez Monroy
[not found] ` <1422623694-6430-5-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-02 12:18 ` Iremonger, Bernard
2015-02-06 15:05 ` [PATCH v3 0/5] New Reorder Library Sergio Gonzalez Monroy
[not found] ` <1423235164-3808-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-06 15:06 ` [PATCH v3 1/5] reorder: new reorder library Sergio Gonzalez Monroy
2015-02-06 15:06 ` [PATCH v3 2/5] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-06 15:06 ` [PATCH v3 3/5] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-06 15:06 ` [PATCH v3 4/5] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-06 15:06 ` [PATCH v3 5/5] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-08 13:58 ` [PATCH v3 0/5] New Reorder Library Neil Horman
[not found] ` <20150208135833.GC12309-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
2015-02-11 11:17 ` Gonzalez Monroy, Sergio
2015-02-11 13:07 ` [PATCH v4 " Sergio Gonzalez Monroy
[not found] ` <1423660055-23920-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-11 13:07 ` [PATCH v4 1/5] reorder: new reorder library Sergio Gonzalez Monroy
2015-02-11 13:07 ` [PATCH v4 2/5] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-11 13:07 ` [PATCH v4 3/5] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-11 13:07 ` [PATCH v4 4/5] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-11 13:07 ` [PATCH v4 5/5] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-12 5:33 ` [PATCH v4 0/5] New Reorder Library Neil Horman
2015-02-12 12:00 ` Declan Doherty
2015-02-18 14:22 ` Thomas Monjalon
2015-02-18 14:36 ` Gonzalez Monroy, Sergio
2015-02-18 14:58 ` [PATCH v5 0/6] " Sergio Gonzalez Monroy
[not found] ` <1424271498-23583-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-18 14:58 ` [PATCH v5 1/6] reorder: new reorder library Sergio Gonzalez Monroy
[not found] ` <1424271498-23583-2-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-19 9:20 ` Olivier MATZ
[not found] ` <54E5AAF9.9010705-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-19 9:50 ` Olivier MATZ
2015-02-18 14:58 ` [PATCH v5 2/6] app: New reorder unit test Sergio Gonzalez Monroy
2015-02-18 14:58 ` [PATCH v5 3/6] examples: new sample app packet_ordering Sergio Gonzalez Monroy
2015-02-18 14:58 ` [PATCH v5 4/6] doc: new reorder library description Sergio Gonzalez Monroy
2015-02-18 14:58 ` [PATCH v5 5/6] doc: new packet ordering app description Sergio Gonzalez Monroy
2015-02-18 14:58 ` [PATCH v5 6/6] MAINTAINERS: add and claim reorder Sergio Gonzalez Monroy
2015-02-18 15:52 ` [PATCH v5 0/6] New Reorder Library Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9416100.1lhCgRCuAQ@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).