From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] librte_reorder: New reorder library Date: Tue, 20 Jan 2015 09:00:38 +0100 Message-ID: <9416100.1lhCgRCuAQ@xps13> References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Reshma Pattan Return-path: In-Reply-To: <1420648753-17136-1-git-send-email-reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, 2015-01-07 16:39, Reshma Pattan: > 1)New library to provide reordering of out of ordered > mbufs based on sequence number of mbuf. Library uses reorder buffer structure > which in tern uses two circular buffers called ready and order buffers. > *rte_reorder_create API creates instance of reorder buffer. > *rte_reorder_init API initializes given reorder buffer instance. > *rte_reorder_reset API resets given reorder buffer instance. > *rte_reorder_insert API inserts the mbuf into order circular buffer. > *rte_reorder_fill_overflow moves mbufs from order buffer to ready buffer > to accomodate early packets in order buffer. > *rte_reorder_drain API provides draining facility to fetch out > reordered mbufs from order and ready buffers. > > Signed-off-by: Reshma Pattan > Signed-off-by: Richardson Bruce I think 2 things are missing in this patchset: 1) Could you show some performance numbers to compare a simple forwarding with and without this library, in the commit log? 2) Could you add some documentation in doc/ directory for programmer's guide? Thank you -- Thomas