From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] app/testpmd: fix PF/VF check of flow director Date: Tue, 25 Oct 2016 23:08:59 +0200 Message-ID: <9425531.GtZQfLiE8F@xps13> References: <1476067628-30842-1-git-send-email-wenzhuo.lu@intel.com> <1476839535-1220-1-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Wenzhuo Lu Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 9D1E42BDF for ; Tue, 25 Oct 2016 23:09:01 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id c78so187000069wme.0 for ; Tue, 25 Oct 2016 14:09:01 -0700 (PDT) In-Reply-To: <1476839535-1220-1-git-send-email-wenzhuo.lu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-19 09:12, Wenzhuo Lu: > Parameters pf & vf are added into most of flow director > filter CLIs. > But mac-valn and tunnel filters don't have these parameters, > the parameters should not be checked for mac-vlan and tunnel > filters. > > Fixes: e6a68c013353 ("app/testpmd: extend commands for flow director in VF") > > Signed-off-by: Wenzhuo Lu > Acked-by: Pablo de Lara This bug was reported and fixed by Frederico Cadete: http://dpdk.org/patch/15264 We have waited long to have a review saying it requires an optional parameter in the command line. And finally you re-post a fixed version of the same approach without any comment to the original thread or a reference here. Please be more careful with occasional contributors. Applied with Reported-by: Frederico Cadete