From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Fix KNI compiling issue on IBM Power Date: Fri, 05 Dec 2014 15:52:36 +0100 Message-ID: <94521173.H6dyulnjbO@xps13> References: <1417688048-23076-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1585880.VN9dgqiZzk@xps13> <20141205144200.GC29245@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: <20141205144200.GC29245-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-05 09:42, Neil Horman: > On Fri, Dec 05, 2014 at 02:10:27PM +0100, Thomas Monjalon wrote: > > 2014-12-04 15:05, Neil Horman: > > > On Thu, Dec 04, 2014 at 04:59:59PM +0100, Thomas Monjalon wrote: > > > > I'm convinced we need to work on the build system but it's anot= her discussion > > > > for next weeks. Speaking about that, the AF_PACKET PMD cannot b= e enabled because > > > > dependencies are not checked before building it. > > > >=20 > > > I'm fine with that. If we're going to make the build system cont= ain a depedency > > > checking mechanism, we'll start dynamically enabling them when su= pport is > > > detected. Until then I'm fine with it being an opt in operation,= as you know at > > > build time what you're minimum kernel support levels are. > > >=20 > > > Speaking of enabling however, be careful of a double standard her= e. I know that > > > igb_uio won't build on some kernels either (linvlle posted in the= > > > irc channel about it earlier), because we don't detect the presen= ce of needed > > > defines. Yet IGB_UIO is still universally enabled... > >=20 > > I'm really surprised. Please post an email to report the problem. > > To my knowledge, igb_uio build on every supported Linux distributio= ns > > (kernel >=3D 2.6.32). > >=20 >=20 > From the IRC session: >=20 > linville CC [M] > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.o > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c: > In function =E2=80=98store_max_vfs=E2=80=99: > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:86:2: > error: implicit declaration of function =E2=80=98strict_strtoul=E2=80= =99 > [-Werror=3Dimplicit-function-declaration] > linville if (0 !=3D strict_strtoul(buf, 0, &max_vfs)) > linville ^ Yes, this issue is being fixed. Jincheng Miao should send a v3: =09http://dpdk.org/ml/archives/dev/2014-December/009182.html > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c: > In function =E2=80=98igbuio_dom0_mmap_phys=E2=80=99: > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:290:30: > error: =E2=80=98_PAGE_IOMAP=E2=80=99 undeclared (first use in this fu= nction) > linville vma->vm_page_prot.pgprot |=3D _PAGE_IOMAP; > linville ^ Xen is disabled by default. So this issue hasn't been raised yet. Fixes are welcome. > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:290:30: > note: each undeclared identifier is reported only once for each funct= ion it > appears in > linville cc1: all warnings being treated as errors > linville does igb_uio only work with certain old kernels? > linville I'm running 3.18-rc7 There are some bugs. Thanks for reporting (it would more visible in another thread). --=20 Thomas