From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal/armv7: emulate vaddvq u16 variant
Date: Mon, 10 Jul 2017 09:32:27 +0200
Message-ID: <9464025.1hzSdOLmaj@xps>
References: <20170707162654.4638-1-jerin.jacob@caviumnetworks.com>
 <CAP4Qi39hJNsgLY0KCk1MdiNG84v-5pJZbmDCBq9pZxFyNbkBOg@mail.gmail.com>
 <1577823.H7hr8NYHfM@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>
To: Jianbo Liu <jianbo.liu@linaro.org>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 72FCA7CA9
 for <dev@dpdk.org>; Mon, 10 Jul 2017 09:32:29 +0200 (CEST)
In-Reply-To: <1577823.H7hr8NYHfM@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/07/2017 09:28, Thomas Monjalon:
> 10/07/2017 05:51, Jianbo Liu:
> > On 9 July 2017 at 01:08, Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 07/07/2017 18:26, Jerin Jacob:
> > >> vaddvq_u16() is not available for armv7.
> > >> Emulate the vaddvq_u16() using armv7 NEON intrinsics.
> > >
> > > After implementing this function, another missing function appears:
> > >
> > >         lib/librte_sched/rte_sched.c:1747:7: error:
> > >         implicit declaration of function =E2=80=98vminvq_u32=E2=80=99
> >=20
> > But sched_vector is disabled in defconfig_arm-armv7a-linuxapp-gcc:
> >     CONFIG_RTE_SCHED_VECTOR=3Dn
>=20
> Yes, I really need to fix test-build.sh which is enabling SCHED_VECTOR.
>=20
> So with this patch, the error remains:
> examples/l3fwd/l3fwd_neon.h:113:6: error:
> implicit declaration of function =E2=80=98vaddvq_u16=E2=80=99
>   v =3D vaddvq_u16(dp1);
>       ^~~~~~~~~~
>=20
> We need to include rte_vect.h.

=46orget it, I mixed up my branches :/

So the patch is OK, compilation is fixed.