From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH RFC v3 0/3] Thread safe rte_vhost_enqueue_burst(). Date: Fri, 18 Mar 2016 09:09:04 +0100 Message-ID: <9470086.ZYvecjaNVJ@xps13> References: <1456314438-4021-1-git-send-email-i.maximets@samsung.com> <10269895.UfVQWhbqLk@xps13> <20160318080035.GS979@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ilya Maximets , Huawei Xie , bruce.richardson@intel.com, dev@dpdk.org, Dyasly Sergey , Jerin Jacob , Jianbo Liu , Tetsuya Mukawa To: Yuanhan Liu Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7190A2BA8 for ; Fri, 18 Mar 2016 09:10:35 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id p65so25683459wmp.0 for ; Fri, 18 Mar 2016 01:10:35 -0700 (PDT) In-Reply-To: <20160318080035.GS979@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-18 16:00, Yuanhan Liu: > On Thu, Mar 17, 2016 at 04:29:32PM +0100, Thomas Monjalon wrote: > > 2016-02-24 14:47, Ilya Maximets: > > > Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer > > > algorithm and contains almost all to be thread-safe, but it's not. > > > > > > This set adds required changes. > > > > > > First patch in set is a standalone patch that fixes many times discussed > > > issue with barriers on different architectures. > > > > > > Second and third adds fixes to make rte_vhost_enqueue_burst thread safe. > > > > My understanding is that we do not want to pollute Rx/Tx with locks. > > > > Huawei, Yuanhan, Bruce, do you confirm? > > Huawei would like to do that, and I'm behind that. Let's do it. I'm not sure to understand. What do you want to do exactly? > The question is can we do that in this release? As I replied in another > thread, I'm wondering we might need do an announce first and do it > in next release? > > Both are Okay to me; I just want to know which one is more proper. > > Thoughts?