From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1] mk: fix external build failure
Date: Mon, 05 Feb 2018 15:07:41 +0100
Message-ID: <94878072.1yUQMxmYxO@xps>
References: <20180205102243.16445-1-marko.kovacevic@intel.com>
 <189741475.qmuB92lqII@xps>
 <6DC05C7C5F25994B81B3F2F214251F66342959@IRSMSX104.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Varghese,
 Vipin" <vipin.varghese@intel.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 09F341B37A
 for <dev@dpdk.org>; Mon,  5 Feb 2018 15:07:46 +0100 (CET)
In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66342959@IRSMSX104.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/02/2018 11:53, Kovacevic, Marko:
> > 05/02/2018 11:22, Marko Kovacevic:
> > > Updated the make build to fix external build issues
> > 
> > Please explain what is the issue.
> > 
> > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project")
> > > Cc: stable@dpdk.org
> > 
> > No need to Cc stable when fixing a bug which is not in a major release.
> 
> Olivier reported an issue this morning, that my commit was breaking 
> the build of one of our external module:
> 
> make[5]: /path/to/ext-module//path/to/ext-module/Makefile: No such file or directory                                                                                                                      
> make[5]: *** No rule to make target '/path/to/ext-module//path/to/ext-module/Makefile'.  Stop.                                                                                                            
> 
> The reason is that entries in $(MAKEFILE_LIST) can be absolute.

I know that :)
I was asking to update the commit message in a v2 actually.