From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] examples: fix RSS hash function configuration
Date: Fri, 29 Jun 2018 13:54:00 +0100
Message-ID: <9511ceba-0515-b738-2db2-8003beec761b@intel.com>
References: <20180620150122.45945-1-ferruh.yigit@intel.com>
 <CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com>
 <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com> <1639218.dJ5v8slQoU@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Dan Gora <dg@adax.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id C56931B5B8
 for <dev@dpdk.org>; Fri, 29 Jun 2018 14:54:02 +0200 (CEST)
In-Reply-To: <1639218.dJ5v8slQoU@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/29/2018 12:55 AM, Thomas Monjalon wrote:
> 20/06/2018 19:15, Ferruh Yigit:
>> On 6/20/2018 6:07 PM, Dan Gora wrote:
>>> Hi Ferruh,
>>>
>>> The documentation for rte_eth_dev_configure() should get updated as
>>> well to document this requirement to strip the unsupported RSS hash
>>> function bits.  The current documentation only refers to the tx/rx
>>> offload bits:
>>>
>>>  *     -  Any offloading set in eth_conf->[rt]xmode.offloads must be within
>>>  *        the [rt]x_offload_capa returned from rte_eth_dev_infos_get().
>>>  *        Any type of device supported offloading set in the input argument
>>>  *        eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled
>>>  *        on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup().
>>
>> Agreed, will update the patch according.
> 
> I don't see the doc updated in your v2.

I have missed it, sending new version with the update.