From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 3/3] ACL: remove subtree_id calculations at
	build stage
Date: Tue, 02 Jun 2015 22:56:40 +0200
Message-ID: <9555737.ZoAvHCuAuV@xps13>
References: <1432316931-18406-1-git-send-email-konstantin.ananyev@intel.com>
 <1432316931-18406-4-git-send-email-konstantin.ananyev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 4DDCC5693
 for <dev@dpdk.org>; Tue,  2 Jun 2015 22:57:30 +0200 (CEST)
Received: by wgez8 with SMTP id z8so150127747wge.0
 for <dev@dpdk.org>; Tue, 02 Jun 2015 13:57:30 -0700 (PDT)
In-Reply-To: <1432316931-18406-4-git-send-email-konstantin.ananyev@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-05-22 18:48, Konstantin Ananyev:
> As now subtree_id is not used acl_merge_trie() any more,
> there is no point to calculate and maintain that information.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

There is an error with GCC 5.1:

lib/librte_acl/acl_bld.c:1324:22: error: array subscript is above array bounds [-Werror=array-bounds]
     end->mrt->results[m] = rule->f->data.userdata;
                      ^
lib/librte_acl/acl_bld.c:1327:22: error: array subscript is above array bounds [-Werror=array-bounds]
     end->mrt->results[m] = 0;
                      ^

This kind of patch fixes it:
-               for (m = 0; m < context->cfg.num_categories; m++) {
+               for (m = 0; m < RTE_MIN(context->cfg.num_categories, RTE_DIM(end->mrt->results)); m++) {