From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/client_server_mp: add sigint
	handler to server
Date: Thu, 27 Sep 2018 13:36:06 +0200
Message-ID: <9568922.17cOiG4SW6@xps>
References: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 303CF1B42D
 for <dev@dpdk.org>; Thu, 27 Sep 2018 13:36:09 +0200 (CEST)
In-Reply-To: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

27/09/2018 13:26, Raslan Darawsheh:
> v2:
> 	- fix includes order

I'm afraid you will need a v3 to fix spacing :)

> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -37,6 +37,7 @@
>  #include "common.h"
>  #include "args.h"
>  #include "init.h"
> +#include<signal.h>

A space is missing here.

> +static void signal_handler(int signal)
> +{
> +	uint16_t port_id;
> +
> +	if (signal == SIGINT)
> +		RTE_ETH_FOREACH_DEV(port_id) {
> +			rte_eth_dev_stop(port_id);
> +			rte_eth_dev_close(port_id);
> +		}
> +	exit(0);
> +}
>  int
>  main(int argc, char *argv[])

A blank line is missing between the functions.