From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ixgbe: fix multi-process support Date: Wed, 10 Dec 2014 14:56:50 +0100 Message-ID: <9583163.sZTCmdctQf@xps13> References: <533710CFB86FA344BFBF2D6802E60286C9D147@SHSMSX101.ccr.corp.intel.com> <1417787182-20712-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1417787182-20712-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-05 13:46, Bruce Richardson: > When using multiple processes, the TX function used in all processes > should be the same, otherwise the secondary processes cannot transmit > more than tx-ring-size - 1 packets. > To achieve this, we extract out the code to select the ixgbe TX function > to be used into a separate function inside the ixgbe driver, and call > that from a secondary process when it is attaching to an > already-configured NIC. > > Testing with symmetric MP app shows that we are able to RX and TX from > both primary and secondary processes once this patch is applied. > > Signed-off-by: Bruce Richardson > > ---- > V2 Changes: > * Moved check for primary/secondary process into set_tx_function instead > of ixgbe_txq_vec_setup, which reduces scope of diff. > * Added/cleaned up some code comments for this change Anyone to review this patch? Thanks -- Thomas