From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: Make XEN_PMD build in combined library mode - v2 Date: Fri, 04 Dec 2015 20:08:10 +0100 Message-ID: <9620658.jHQ3iUiUeS@xps13> References: <1449126263-18796-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id D8C8A922F for ; Fri, 4 Dec 2015 20:09:20 +0100 (CET) Received: by wmuu63 with SMTP id u63so74004605wmu.0 for ; Fri, 04 Dec 2015 11:09:20 -0800 (PST) In-Reply-To: <1449126263-18796-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-03 08:04, Christian Ehrhardt: > Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was > enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). > Now the underlying issue is rather simple, the xen code needs libxenstore. > But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was > disabled. > While it is correct to create the DPDK sublib linking only in the > RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked > libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled. > > Updates in Version 2: > Move it out of the --start-group as well > > Signed-off-by: Christian Ehrhardt Reported-by: Thiago Martins Applied, thanks