From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 0/6] get status of Rx and Tx descriptors
Date: Wed, 19 Apr 2017 16:50:03 +0100
Message-ID: <964704da-42e8-203d-62bb-29f9c17eac92@intel.com>
References: <1488902393-7237-1-git-send-email-olivier.matz@6wind.com>
 <20170329083633.15626-1-olivier.matz@6wind.com> <6733058.qxCdJeOGN1@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com,
 jingjing.wu@intel.com, adrien.mazarguil@6wind.com,
 nelio.laranjeiro@6wind.com, bruce.richardson@intel.com,
 venky.venkatesan@intel.com, arybchenko@solarflare.com, qiming.yang@intel.com
To: Jing Chen <jing.d.chen@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 8A52D388F
 for <dev@dpdk.org>; Wed, 19 Apr 2017 17:50:12 +0200 (CEST)
In-Reply-To: <6733058.qxCdJeOGN1@xps13>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2017 2:30 PM, Thomas Monjalon wrote:
> 2017-03-29 10:36, Olivier Matz:
>> This patchset introduces a new ethdev API:
>> - rte_eth_rx_descriptor_status()
>> - rte_eth_tx_descriptor_status()
>>
>> The Rx API is aims to replace rte_eth_rx_descriptor_done() which
>> does almost the same, but does not differentiate the case of a
>> descriptor used by the driver (not returned to the hw).
>>
>> The usage of these functions can be:
>> - on Rx, anticipate that the cpu is not fast enough to process
>>   all incoming packets, and take dispositions to solve the
>>   problem (add more cpus, drop specific packets, ...)
>> - on Tx, detect that the link is overloaded, and take dispositions
>>   to solve the problem (notify flow control, drop specific
>>   packets)
>>
>> The patchset updates ixgbe, i40e, e1000, mlx5.
>> The other drivers that implement the descriptor_done() API are
>> fm10k, sfc, virtio. They are not updated.

Reminder for following PMDs:
- fm10k
- sfc
- virtio

There are two new eth_dev_ops:
rx_descriptor_status
tx_descriptor_status

"rx_descriptor_status" replaces "rx_descriptor_done"

It is suggested to switch to new one, and implement tx_descriptor_status

Thanks,
ferruh

>> If the new API is accepted, the descriptor_done() can be deprecated,
>> and examples/l3fwd-power will be updated to.
> 
> Applied, thanks
> 
> Next steps:
> - implement it in other drivers
> - deprecate descriptor_done API
> 
> Ferruh, please, could you check with drivers maintainers?
> Thanks
>