From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/3] net/thunderx: disable pmd for older
	compilers
Date: Thu, 6 Apr 2017 15:46:01 +0100
Message-ID: <9652ec20-0878-83dc-a93e-167f862fd7e8@intel.com>
References: <20170406121428.16883-1-ferruh.yigit@intel.com>
 <2608561.Cu0AakAGmg@xps13> <f8561c7b-59ef-99fc-e180-b9ad60608a31@intel.com>
 <9561885.LnGWdCXozX@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9BB422B84
 for <dev@dpdk.org>; Thu,  6 Apr 2017 16:46:04 +0200 (CEST)
In-Reply-To: <9561885.LnGWdCXozX@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/6/2017 3:09 PM, Thomas Monjalon wrote:
> 2017-04-06 15:05, Ferruh Yigit:
>> On 4/6/2017 2:59 PM, Thomas Monjalon wrote:
>>> 2017-04-06 14:46, Ferruh Yigit:
>>>> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
>>>> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
>>>> @@ -89,4 +89,8 @@ else
>>>>  	ifeq ($(shell test $(GCC_VERSION) -lt 42 && echo 1), 1)
>>>>  		MACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS))
>>>>  	endif
>>>> +
>>>> +	ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
>>>> +		CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n
>>>> +	endif
>>>
>>> In previous version you were disabling the PMD inside the PMD Makefile.
>>> It was better.
>>
>> Agreed, but I that is causing a build error in applications. I have
>> missed it in previous release because an .a file was already created.
>>
>> So, need a way to disable linking pmd against application.
> 
> I see.
> 
> If it is disabled here, we won't see the warning in the PMD Makefile?

Oh, you are right, warnings in PMD Makefile become useless.

I can set another flag in compat headers and check it in pmd makefile,
will it be too much noise?