From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [RFC] cmdline: rework as a wrapper to libedit
Date: Thu, 16 Nov 2017 17:27:37 +0000
Message-ID: <966D87A8-0B36-4B01-862C-EC9DB55667B3@intel.com>
References: <1510234868-31053-1-git-send-email-adrien.mazarguil@6wind.com>
 <48C2CD08-29E1-444C-BF60-B96BE58865A5@intel.com>
 <20171116092356.GM24849@6wind.com>
 <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Olivier Matz
 <olivier.matz@6wind.com>, "Wu, Jingjing" <jingjing.wu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0BFE11B206
 for <dev@dpdk.org>; Thu, 16 Nov 2017 18:27:39 +0100 (CET)
In-Reply-To: <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com>
Content-Language: en-US
Content-ID: <675503EF6FBD3246910B59C09E5C209D@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote=
:
>=20
> On 11/16/2017 1:23 AM, Adrien Mazarguil wrote:
> <...>
>=20
>>> I do not agree it has severed DPDK well, just look at test-pmd and the =
hoops people have to jump thru to get a new command or variation of an exis=
ting command integrated into test-pmd it is very difficult. Also if you loo=
k at the command sets in test-pmd they are very odd in that similar command=
s can some times be set up completely different as cmdline is too rigid and=
 difficult to use.
>>=20
>> Testpmd is indeed messy, but this is not librte_cmdline's fundamental fa=
ult
>> in my opinion, more likely the result of using a copy/paste approach to =
new
>> commands due to lack of time or interest in making things nicer than the
>> bare minimum to validate features. There's no design direction for it he=
nce
>> the lack of uniformity in the command hierarchy.
>=20
> Unrelated to cmdline discussion +1 for this paragraph.

As a side note should CLI change the test-pmd commands to be more reasonabl=
e or maintain the current commands to not break testing. I would like to fi=
x these commands with CLI, but as I have both built into test-pmd currently=
 we can could keep the old cmdline commands and if you use the new CLI then=
 it would be the new cleaner commands.

Regards,
Keith