From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Date: Fri, 17 Oct 2014 09:39:52 +0200 Message-ID: <9682370.k5Gd5eGDQ1@xps13> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <3781474.dkZOSRuQuF@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Liu, Jijiang" Return-path: In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-17 05:58, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-10-11 13:55, Jijiang Liu: > > > # > > > +# Compile tunneling UDP port support > > > +# > > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789 > > > + > > > +# > > > > 1) this option is not to "Compile tunneling UDP port support" > Change the comment as "tunneling UDP default port configuration" > > 2) why is it a compile time option? should it be an API parameter or a > > runtime option? > > In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port, > and this value SHOULD be used by default as the destination UDP port. > Some early implementations of VXLAN have used other values for the > destination port. To enable interoperability with these implementations, > the destination port SHOULD be configurable." Please, do not consider a compile time option like "configurable". There are some cases where the user cannot or don't want to rebuild DPDK. > I have provided a API to configure UDP port. OK, good. > But a default UDP port number is needed where PF startup if current mode is > VxLAN mode. Sorry, I don't understand this part. Why are you adding a default tunnel when initializing? Is it not enough to allow adding new tunnels with custom port? -- Thomas