From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] lib: remove "extern" keyword for functions
	from header files
Date: Wed, 27 Jan 2016 19:05:52 +0100
Message-ID: <96929867.upEFuzBccp@xps13>
References: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id C6937C134
 for <dev@dpdk.org>; Wed, 27 Jan 2016 19:07:01 +0100 (CET)
Received: by mail-wm0-f41.google.com with SMTP id p63so39035928wmp.1
 for <dev@dpdk.org>; Wed, 27 Jan 2016 10:07:01 -0800 (PST)
In-Reply-To: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-01-25 10:01, Ferruh Yigit:
> Remove "extern" keywords in header files, the ones for function
> prototypes

I've seen a lot of other extern keywords. Why not removing all?

> -extern int rte_eth_dev_configure(uint8_t port_id,
> -				 uint16_t nb_rx_queue,
> -				 uint16_t nb_tx_queue,
> -				 const struct rte_eth_conf *eth_conf);
> +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue,
> +			  uint16_t nb_tx_queue,
> +			  const struct rte_eth_conf *eth_conf);

The indent is weird.
Why not follow the guideline with 2 tabs?
http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation