From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH v1] crypto/scheduler: fix multicore scheduler reordering Date: Wed, 19 Jul 2017 15:03:09 +0100 Message-ID: <96dc8c1e-b5a7-2de7-93db-4b53d7d04d5f@intel.com> References: <1500374138-6262-1-git-send-email-kirill.rybalchenko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Kirill Rybalchenko , roy.fan.zhang@intel.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A3F0A2030 for ; Wed, 19 Jul 2017 16:03:16 +0200 (CEST) In-Reply-To: <1500374138-6262-1-git-send-email-kirill.rybalchenko@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18/07/2017 11:35 AM, Kirill Rybalchenko wrote: > Operations can be dequeued from the reordering ring only after they > were dequeued from the crypto pmd with rte_cryptodev_dequeue_burst() > function. It is not correct to dequeue them when status just changed > from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED to any other value, as the > operations still can be processed by crypto pmd internally. > Now multicore scheduler workers mark status of all dequeued from > crypto pmd operations with CRYPTO_OP_STATUS_BIT_COMPLETE bit set. > Scheduler will dequeue crypto operations from reordering ring only > when this status bit is set. Prior to put this operation to output > buffer, scheduler clears this bit, so the application gets > unmodified status from crypto pmd. > > Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") > > Signed-off-by: Kirill Rybalchenko > --- ... > Acked-by: Declan Doherty