From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C12AC433E0 for ; Mon, 13 Jul 2020 12:52:59 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E3CAA206F0 for ; Mon, 13 Jul 2020 12:52:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3CAA206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 584F71D6FB; Mon, 13 Jul 2020 14:52:58 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 111B51B75C for ; Mon, 13 Jul 2020 14:52:55 +0200 (CEST) IronPort-SDR: tWcfH945szthWy5TWgoICaPhBZpR0dvkxfg2R+AcXYzfYTzq8ZB53+LixhNu+9JZSQo1C7oH0X 3AZq2OV6UXBw== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="128657097" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="128657097" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:52:55 -0700 IronPort-SDR: a4krdkM3+6bmZjyZjQrqBx6fpqs64gyOyYDUPbP3GxKeotYG3zC46ILxiJK0hGPm/CNjQ/Wyrr DmCnUciL4FBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459281431" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.225.87]) ([10.213.225.87]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2020 05:52:54 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-6-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: <979bd2e3-25ee-6fe2-358e-fd352b1d15d5@intel.com> Date: Mon, 13 Jul 2020 13:52:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200701202359.17006-6-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 05/27] drivers: replace master/slave terminology X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > Replace rte_get_master_lcore() with rte_get_initial_lcore(). > Replace RTE_LCORE_FOREACH_SLAVE with RTE_LCORE_FOREACH_WORKER > > Signed-off-by: Stephen Hemminger > --- Comments in pci_common_uio.c:54 and vmbus_common_uio.c:88 refers to secondary process as "slave", should probably fix that too. You mentioned "bonding" driver as needing work but there's actually a whole bunch of instances of such terminology being used internally in other drivers as well (e.g. cryptodev scheduler). A quick grep on "master|slave" gives us a huge list of files, and while some of them are spec terms (e.g. PCI bus mastering), a lot of them aren't. I'm of course not suggesting it all should be done in this patch, just noting that bonding isn't the only driver needing work :) As for contents of this patch (provided the corrections mentioned above are done), Reviewed-by: Anatoly Burakov -- Thanks, Anatoly