From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/tap: add missing newlines in logs Date: Tue, 18 Jul 2017 08:51:57 +0100 Message-ID: <97a7ff76-3370-12d3-164d-72375f3e0906@intel.com> References: <20170706152848.26632-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Pascal Mazon , Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BAEA23253 for ; Tue, 18 Jul 2017 09:52:03 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/10/2017 8:07 AM, Pascal Mazon wrote: > > On 07/06/2017 05:28 PM, Thomas Monjalon wrote: >> Some logs are missing the newline character \n. >> >> The logs using only line can be checked with this command: >> git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/ This shows that some other drivers have same problem. Any volunteer to fix them are quite welcome. >> >> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") >> Fixes: 268483dc2086 ("net/tap: add preliminary support for flow API") >> Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture") >> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") >> >> Signed-off-by: Thomas Monjalon > Acked-by: Pascal Mazon Applied to dpdk-next-net/master, thanks.