From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 36/53] net/sfc/base: run mkconfig.py to add a
 new sensors
Date: Mon, 27 Nov 2017 11:58:12 -0800
Message-ID: <97b17ccf-ce79-5196-240d-d77eda9f684c@intel.com>
References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com>
 <1510819481-6809-37-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Andy Moreton <amoreton@solarflare.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 229513259
 for <dev@dpdk.org>; Mon, 27 Nov 2017 20:58:13 +0100 (CET)
In-Reply-To: <1510819481-6809-37-git-send-email-arybchenko@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/16/2017 12:04 AM, Andrew Rybchenko wrote:
> From: Andy Moreton <amoreton@solarflare.com>

We don't know what mkconfig.py is and most probably not interested in :) This
looks like your internal detail, more interesting is the effect of this change,
like "add new sensors".

btw, just out of curiosity, what sensors are they?

> 
> Signed-off-by: Andy Moreton <amoreton@solarflare.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  drivers/net/sfc/base/efx.h     | 4 +++-
>  drivers/net/sfc/base/efx_mon.c | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h
> index df1594e..b809819 100644
> --- a/drivers/net/sfc/base/efx.h
> +++ b/drivers/net/sfc/base/efx.h
> @@ -627,7 +627,7 @@ efx_mon_init(
>  #define	EFX_MON_STATS_PAGE_SIZE 0x100
>  #define	EFX_MON_MASK_ELEMENT_SIZE 32
>  
> -/* START MKCONFIG GENERATED MonitorHeaderStatsBlock 5d4ee5185e419abe */
> +/* START MKCONFIG GENERATED MonitorHeaderStatsBlock aa0233c80156308e */
>  typedef enum efx_mon_stat_e {
>  	EFX_MON_STAT_2_5V,
>  	EFX_MON_STAT_VCCP1,
> @@ -706,6 +706,8 @@ typedef enum efx_mon_stat_e {
>  	EFX_MON_STAT_CONTROLLER_TDIODE_TEMP,
>  	EFX_MON_STAT_BOARD_FRONT_TEMP,
>  	EFX_MON_STAT_BOARD_BACK_TEMP,
> +	EFX_MON_STAT_I1V8,
> +	EFX_MON_STAT_I2V5,
>  	EFX_MON_NSTATS
>  } efx_mon_stat_t;
>  
> diff --git a/drivers/net/sfc/base/efx_mon.c b/drivers/net/sfc/base/efx_mon.c
> index c2f1e97..6074760 100644
> --- a/drivers/net/sfc/base/efx_mon.c
> +++ b/drivers/net/sfc/base/efx_mon.c
> @@ -123,7 +123,7 @@ efx_mon_init(
>  
>  #if EFSYS_OPT_NAMES
>  
> -/* START MKCONFIG GENERATED MonitorStatNamesBlock 5daa2a5725ba734b */
> +/* START MKCONFIG GENERATED MonitorStatNamesBlock d92af1538001301f */
>  static const char * const __mon_stat_name[] = {
>  	"value_2_5v",
>  	"value_vccp1",
> @@ -202,6 +202,8 @@ static const char * const __mon_stat_name[] = {
>  	"controller_tdiode_temp",
>  	"board_front_temp",
>  	"board_back_temp",
> +	"i1v8",
> +	"i2v5",
>  };
>  
>  /* END MKCONFIG GENERATED MonitorStatNamesBlock */
>