From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] eal: remove experimental tag for
	probe/remove
Date: Tue, 06 Nov 2018 00:08:37 +0100
Message-ID: <9843117.IEzvs299zs@xps>
References: <20181101144633.13429-1-thomas@monjalon.net>
 <13462be0-7835-144a-143f-1e0d30343503@redhat.com> <1715062.3G7La7yUx6@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Kevin Traynor <ktraynor@redhat.com>, ophirmu@mellanox.com,
 ferruh.yigit@intel.com, arybchenko@solarflare.com, ian.stokes@intel.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AB38D4F9B
 for <dev@dpdk.org>; Tue,  6 Nov 2018 00:08:40 +0100 (CET)
In-Reply-To: <1715062.3G7La7yUx6@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

05/11/2018 14:13, Thomas Monjalon:
> 05/11/2018 13:19, Kevin Traynor:
> > On 11/01/2018 02:46 PM, Thomas Monjalon wrote:
> > > The functions rte_dev_probe() and rte_dev_remove() are new
> > > in DPDK 18.11 so they got the experimental tag by policy.
> > > However they are too much basic functions for being skipped
> > > by strict applications which do not use experimental functions.
> > > 
> > > The alternative is to use rte_eal_hotplug_add() and
> > > rte_eal_hotplug_remove(), but their API requires the application
> > > to parse the devargs string in order to provide bus name,
> > > device name and driver arguments.
> > > 
> > > The new function rte_dev_probe() is really simpler to use and
> > > more flexible by accepting any devargs string.
> > > Let's encourage applications to use it.
> > > 
> > > The old functions rte_eal_hotplug_* may be deprecated later.
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > one minor comment below, but it's no big deal..
> > 
> > Acked-by: Kevin Traynor <ktraynor@redhat.com>
> > Tested-by: Kevin Traynor <ktraynor@redhat.com>
> [...]
> > > --- a/lib/librte_eal/rte_eal_version.map
> > > +++ b/lib/librte_eal/rte_eal_version.map
> > > @@ -262,6 +262,8 @@ DPDK_18.11 {
> > >  	rte_eal_get_runtime_dir;
> > >  	rte_eal_hotplug_add;
> > >  	rte_eal_hotplug_remove;
> > > +	rte_dev_probe;
> > > +	rte_dev_remove;
> > 
> > maybe you want to keep these in alphabetical order
> 
> Oh yes, I must revise the alphabetical order!
> Thanks

Series applied with above change.