From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/qede: fix advertising link speed capability Date: Fri, 28 Oct 2016 09:26:11 +0200 Message-ID: <9851708.0H4Kn83q5Z@xps13> References: <1772382.AymLqBrjhc@xps13> <1477636922-18546-1-git-send-email-rasesh.mody@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com To: Rasesh Mody Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id B1DEE326B for ; Fri, 28 Oct 2016 09:26:13 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id e69so80454468wmg.0 for ; Fri, 28 Oct 2016 00:26:13 -0700 (PDT) In-Reply-To: <1477636922-18546-1-git-send-email-rasesh.mody@qlogic.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-27 23:42, Rasesh Mody: > From: Harish Patil > > Fix to advertise device's link speed capability based on current > link speed rather than returning driver supported speeds. [...] > - dev_info->speed_capa = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G | > - ETH_LINK_SPEED_100G; > + memset(&link, 0, sizeof(struct qed_link_output)); > + qdev->ops->common->get_link(edev, &link); > + dev_info->speed_capa = rte_eth_speed_bitflag(link.speed, 0); > } No, that's wrong. You must advertise a capability! So what the device supports? Are every qede devices support ETH_LINK_SPEED_100G?