From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 7/8] net/qede: add missing check for VNI
Date: Mon, 3 Jul 2017 11:08:45 +0100
Message-ID: <98563df5-d18b-c80b-4326-445524ee4e6b@intel.com>
References: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com>
 <1498937402-25547-8-git-send-email-rasesh.mody@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Dept-EngDPDKDev@cavium.com
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id A97E61094
 for <dev@dpdk.org>; Mon,  3 Jul 2017 12:08:48 +0200 (CEST)
In-Reply-To: <1498937402-25547-8-git-send-email-rasesh.mody@cavium.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/1/2017 8:30 PM, Rasesh Mody wrote:
> Add missing check for VNI field while adding unicast filter.

Can you please document the result of not having vni field? And if this
is fixing an error, can you please use fixes syntax?

> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
>  drivers/net/qede/qede_ethdev.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ad264ba..a0616a4 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -571,6 +571,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn,
>  		SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
>  			if ((memcmp(mac_addr, &tmp->mac,
>  				    ETHER_ADDR_LEN) == 0) &&
> +			     ucast->vni == tmp->vni &&
>  			     ucast->vlan == tmp->vlan) {
>  				DP_ERR(edev, "Unicast MAC is already added"
>  				       " with vlan = %u, vni = %u\n",
>