From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: Build is broken in dpdk-next-net
Date: Fri, 30 Mar 2018 15:13:55 +0100
Message-ID: <98626f3d-c959-37d2-c238-6babc6272745@intel.com>
References: <a28e7585-c312-8b0e-4e6d-1f6621a35feb@solarflare.com>
 <93d00a28-d52d-25b3-42d0-84b1d95c756a@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id BD23E44BE
 for <dev@dpdk.org>; Fri, 30 Mar 2018 16:13:58 +0200 (CEST)
In-Reply-To: <93d00a28-d52d-25b3-42d0-84b1d95c756a@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2018 2:27 PM, Maxime Coquelin wrote:
> Hi Andrew,
> 
> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote:
>> Hi all,
>>
>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4:
>>
>> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’:
>> lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result]
>>    read(readfd, charbuf, sizeof(charbuf));
>>    ^
>> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_notify’:
>> lib/librte_vhost/fd_man.c:324:2: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result]
>>    write(fdset->u.writefd, "1", 1);
>>    ^
>>
>> $ gcc --version
>> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
> 
> Thanks for reporting, I don't catch it with my Fedora build system:
> $ gcc --version
> gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
> 
>>
>> As I understand it is broken in ad94ade905454401b705be9e06b19e54a1c78148
>> vhost: add pipe event for optimizing negotiating
> 
> I confirm it is this patch.
> 
> Xiangxia, can you provide a fix please?
> 
> Ferruh, how do you want to proceed?
> Would you revert it?

next-net not pulled yet, lets try to fix first, at last resort if there is no
solution we can think about revert

> 
> Thanks,
> Maxime
>> Andrew.
>>