From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/2 v4] Fix two compile issues with i686 platform Date: Thu, 11 Dec 2014 22:21:44 +0100 Message-ID: <9863237.MyFdkOxhYo@xps13> References: <1417684369-21330-1-git-send-email-michael.qiu@intel.com> <20141211132506.GA28213@hmsreliant.think-freely.org> <533710CFB86FA344BFBF2D6802E60286C9EEB1@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9EEB1-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-11 15:28, Qiu, Michael: > On 2014/12/11 21:26, Neil Horman wrote: > > On Thu, Dec 11, 2014 at 01:56:06AM +0100, Thomas Monjalon wrote: > >>> These two issues are both introuduced by commit b77b5639: > >>> mem: add huge page sizes for IBM Power > >>> > >>> Michael Qiu (2): > >>> Fix compile issue with hugepage_sz in 32-bit system > >>> Fix compile issue of eal with icc compile > >> Acked-by: Thomas Monjalon > >> > >> Applied > >> > >> Thanks > >> > > Wait, why did you apply this patch? We had outstanding debate on it, and > > Michael indicated he was testing a new version of the patch. > > Yes, I test the solution you suggest :) and it mostly works, but with a > little issue. > I have re-post not the old version. Neil, v4 is a new version implementing what you suggested. There was no comment and it looks good so I applied it. > Do you take a look at? I think Neil missed the v4. Sorry to not have pinged you, I wanted rc4 for validation at this time. Neil do you agree this version is OK or do you see some issue to fix? -- Thomas