From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: add function name to log message
Date: Fri, 12 Oct 2018 11:42:03 +0100
Message-ID: <98717fc3-c3dd-cc4f-e5ff-b5310e47d6ee@intel.com>
References: <20181011175940.6800-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 291561B184
 for <dev@dpdk.org>; Fri, 12 Oct 2018 12:42:05 +0200 (CEST)
In-Reply-To: <20181011175940.6800-1-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/11/2018 6:59 PM, Stephen Hemminger wrote:
> @@ -161,8 +161,9 @@ extern "C" {
>  
>  extern int rte_eth_dev_logtype;
>  
> -#define RTE_ETHDEV_LOG(level, ...) \
> -	rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__)
> +#define RTE_ETHDEV_LOG(level, fmt, ...)		\
> +	rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \
> +		"%s():" fmt, __func__, ## __VA_ARGS__)

+1 to adding function name, but

failsafe is giving build error [1] with clang because of ## usage [2], that is
why I add this as ` "" __VA_ARGS__` at first place but you can't do this trick
if __VA_ARGS__ used after fmt.

I am not aware of a solution for this, __VA_OPT__(,) also didn't worked with clang.


[1]
.../build/include/rte_ethdev.h:166:26: error: token pasting of ',' and
__VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
                "%s():" fmt, __func__, ## __VA_ARGS__)
                                       ^

[2]
This seems because of "-pedantic" argument driver uses, and other PMDs using
"-pedantic", like mlx,  will have same error although they are disable by
default and error not observed in default build.