From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/3] lib/librte_ether: remove requirement
 of aligned RETA size
Date: Mon, 3 Apr 2017 11:02:19 +0100
Message-ID: <9894d012-a63c-9f5c-b98c-877ec304a817@intel.com>
References: <20170316224056.19685-1-yskoh@mellanox.com>
 <cover.1490050764.git.yskoh@mellanox.com>
 <7783e46e840052a9abdd4e8962eede598ab848af.1490050764.git.yskoh@mellanox.com>
 <1920337.9E3jvcbJyk@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E71AA37C18@SHSMSX103.ccr.corp.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B58649D@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
 "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id E684A2C6E
 for <dev@dpdk.org>; Mon,  3 Apr 2017 12:02:22 +0200 (CEST)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B58649D@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/1/2017 8:28 AM, Lu, Wenzhuo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
<...>
>>> -----Original Message-----
>>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
<...>
>>> 2017-03-20 16:04, Yongseok Koh:
>>>> In rte_eth_check_reta_mask(), it is required to align the size of
>>>> the RETA table to RTE_RETA_GROUP_SIZE but as the size can be less
>>>> than the limit, this should be removed. The change is also applied
>>>> to a command of
>>> testpmd.
>>>>
>>>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>

<...>

>>> There is no comment for this constraint neither in the code nor in the
>>> commit: http://dpdk.org/commit/66c594904 So, I guess it can be removed.
>>> If a check is needed, it could be added in the relevant drivers.
>>>
>>> Helin, Konstantin, please check for Intel drivers.
>> Hi Thomas
>>
>> Thank you very much for the reminder!
>> We will check that and see if there is any impacts to Intel drivers.
> I don't think it has any impact to the drivers.
> To my opinion, it's a good fix as it makes the name ' reta_size' more reasonable.

Series applied to dpdk-next-net/master, thanks.