From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Nawal Kishor" <nkishor@marvell.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <asekhar@marvell.com>
Subject: RE: [PATCH v2 0/2] cnxk: add HALO support for CN20K mempool
Date: Wed, 14 Jan 2026 08:52:28 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65659@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260113220448.56f44b5e@phoenix.local>
> **Warning: Non-portable format specifier**
>
> In `roc_npa_debug.c`, function `npa_halo_dump()`:
> ```c
> npa_dump("W9: thresh \t\t%lu\nW9: fc_msh_dst \t\t%d",
> (unsigned long)halo->thresh, halo->fc_msh_dst);
> ```
>
> The AGENTS.md specifies:
> > Forbidden: `%lld`, `%llu`, `%llx` → Preferred: `%PRId64`, `%PRIu64`,
> `%PRIx64`
>
> While `%lu` with an explicit cast is technically different, for
> consistency with the rest of the file (which uses `%"PRIx64"`
> patterns), this should use:
> ```c
> npa_dump("W9: thresh \t\t%" PRIu64 "\nW9: fc_msh_dst \t\t%d",
> (uint64_t)halo->thresh, halo->fc_msh_dst);
> ```
I'm not sure I agree with this, because the AI suggested fix casts halo->thresh to 64 bit on 32 bit architectures (which there is no need for).
next prev parent reply other threads:[~2026-01-14 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 6:51 [PATCH 0/2] cnxk: Add HALO support for CN20K mempool Nawal Kishor
2025-12-04 6:51 ` [PATCH 1/2] common/cnxk: add support for halos Nawal Kishor
2025-12-05 5:51 ` [PATCH v2 0/2] cnxk: add HALO support for CN20K mempool Nawal Kishor
2025-12-05 5:51 ` [PATCH v2 1/2] common/cnxk: add support for halos Nawal Kishor
2025-12-05 5:51 ` [PATCH v2 2/2] mempool/cnxk: add halo support in mempool Nawal Kishor
2026-02-17 5:34 ` [PATCH v3 0/2] Add HALO support for CN20K mempool Nawal Kishor
2026-02-17 5:34 ` [PATCH v3 1/2] common/cnxk: add support for halos Nawal Kishor
2026-02-17 5:34 ` [PATCH v3 2/2] mempool/cnxk: add halo support in mempool Nawal Kishor
2026-02-17 8:43 ` [PATCH v3 0/2] Add HALO support for CN20K mempool Jerin Jacob
2026-02-17 10:39 ` [PATCH v4 " Nawal Kishor
2026-02-17 10:39 ` [PATCH v4 1/2] common/cnxk: add support for halos Nawal Kishor
2026-02-19 17:19 ` Stephen Hemminger
2026-02-17 10:39 ` [PATCH v4 2/2] mempool/cnxk: add halo support in mempool Nawal Kishor
2026-02-19 17:33 ` Stephen Hemminger
2026-01-14 6:04 ` [PATCH v2 0/2] cnxk: add HALO support for CN20K mempool Stephen Hemminger
2026-01-14 7:52 ` Morten Brørup [this message]
2026-01-19 5:21 ` [EXTERNAL] " Nawal Kishor
2025-12-04 6:51 ` [PATCH 2/2] mempool/cnxk: add halo support in mempool Nawal Kishor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65659@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nkishor@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox