From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, "Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>
Subject: RE: [PATCH v6] eal/x86: optimize memcpy of small sizes
Date: Tue, 20 Jan 2026 12:22:43 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65677@smartserver.smartshare.dk> (raw)
In-Reply-To: <PH7PR12MB8596F1FE29BA757F8884E7A98289A@PH7PR12MB8596.namprd12.prod.outlook.com>
> From: Varghese, Vipin [mailto:Vipin.Varghese@amd.com]
> Sent: Tuesday, 20 January 2026 12.19
>
> [Public]
>
> Hi @Morten Brørup, quick query in function `rte_mov17_to_32`
>
> ```
> + if (__rte_constant(n)) {
> + if (n == 16) {
> + rte_mov16((uint8_t *)dst, (const uint8_t
> *)src);
> + rte_mov1((uint8_t *)dst + 16, (const uint8_t
> *)src + 16);
> + return dst;
> + }
> + if (n == 17) {
> + rte_mov16((uint8_t *)dst, (const uint8_t
> *)src);
> + rte_mov1((uint8_t *)dst + 16, (const uint8_t
> *)src + 16);
> + return dst;
> + }
> ```
>
> For `size 16` do we need to call ` rte_mov1((uint8_t *)dst + 16, (const
> uint8_t *)src + 16);`? Can you please help me understand the corner
> case for the same.
Good catch!
Copy-paste bug.
Will fix in next version, awaiting other feedback.
next prev parent reply other threads:[~2026-01-20 11:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 11:45 [PATCH] eal/x86: reduce memcpy code duplication Morten Brørup
2025-11-21 10:35 ` [PATCH v2] eal/x86: optimize memcpy of small sizes Morten Brørup
2025-11-21 16:57 ` Stephen Hemminger
2025-11-21 17:02 ` Bruce Richardson
2025-11-21 17:11 ` Stephen Hemminger
2025-11-21 21:36 ` Morten Brørup
2025-11-21 10:40 ` Morten Brørup
2025-11-21 10:40 ` [PATCH v3] " Morten Brørup
2025-11-24 13:36 ` Morten Brørup
2025-11-24 15:46 ` Patrick Robb
2025-11-28 14:02 ` Konstantin Ananyev
2025-11-28 15:55 ` Morten Brørup
2025-11-28 18:10 ` Konstantin Ananyev
2025-11-29 2:17 ` Morten Brørup
2025-12-01 9:35 ` Konstantin Ananyev
2025-12-01 10:41 ` Morten Brørup
2025-11-24 20:31 ` [PATCH v4] " Morten Brørup
2025-11-25 8:19 ` Morten Brørup
2025-12-01 15:55 ` [PATCH v5] " Morten Brørup
2025-12-03 13:29 ` Morten Brørup
2026-01-03 17:53 ` Morten Brørup
2026-01-09 15:05 ` Varghese, Vipin
2026-01-11 15:52 ` Konstantin Ananyev
2026-01-11 16:01 ` Stephen Hemminger
2026-01-12 8:02 ` Morten Brørup
2026-01-12 16:00 ` Scott Mitchell
2026-01-13 0:39 ` Stephen Hemminger
2026-01-12 12:03 ` [PATCH v6] " Morten Brørup
2026-01-13 23:19 ` Stephen Hemminger
2026-01-20 11:00 ` Varghese, Vipin
2026-01-20 11:19 ` Varghese, Vipin
2026-01-20 11:22 ` Morten Brørup [this message]
2026-01-21 11:48 ` Varghese, Vipin
2026-01-22 6:59 ` Varghese, Vipin
2026-01-22 7:28 ` Liangxing Wang
2026-01-23 6:58 ` Varghese, Vipin
2026-02-20 11:08 ` [PATCH v7] " Morten Brørup
2026-03-11 7:28 ` Morten Brørup
2026-03-11 16:58 ` Bruce Richardson
2026-03-11 18:29 ` Morten Brørup
2026-03-11 19:09 ` Bruce Richardson
2026-03-12 8:33 ` Konstantin Ananyev
2026-03-19 15:55 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65677@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Vipin.Varghese@amd.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox