From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: RE: [PATCH 0/4] examples: memcpy cleanups
Date: Wed, 21 Jan 2026 19:55:03 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65689@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260121170540.785735-1-stephen@networkplumber.org>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, 21 January 2026 18.05
>
> Looking at examples and noticed stuff around use
> of rte_memcpy. Probably mostly copy/pasted.
>
> Stephen Hemminger (4):
> examples/vhost: replace memcpy with assignment
> examples/vmdq: replace memcpy with structure assignment
> examples/vmdq_dcb: replace memcpy with assignment
> examples: remove unnecessary include
>
Structure assignment is better than [rte_]memcpy().
And this is slow path only, so no need to discuss performance.
For the series,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Thank you for cleaning this up.
next prev parent reply other threads:[~2026-01-21 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 17:04 [PATCH 0/4] examples: memcpy cleanups Stephen Hemminger
2026-01-21 17:04 ` [PATCH 1/4] examples/vhost: replace memcpy with assignment Stephen Hemminger
2026-01-21 17:04 ` [PATCH 2/4] examples/vmdq: replace memcpy with structure assignment Stephen Hemminger
2026-01-21 17:04 ` [PATCH 3/4] examples/vmdq_dcb: replace memcpy with assignment Stephen Hemminger
2026-01-21 17:04 ` [PATCH 4/4] examples: remove unnecessary include Stephen Hemminger
2026-02-17 17:43 ` Thomas Monjalon
2026-01-21 18:55 ` Morten Brørup [this message]
2026-02-17 17:49 ` [PATCH 0/4] examples: memcpy cleanups Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65689@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox