From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>
Subject: RE: [PATCH 3/3] drivers: always enable the null net driver [RFC]
Date: Thu, 22 Jan 2026 14:13:06 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F6568E@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260122122354.1820368-4-bruce.richardson@intel.com>
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Thursday, 22 January 2026 13.24
>
> Having the net_null driver always available can be convenient and
> allows
> use by unit tests, so add this trivial driver to the always-enable
> list.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> ---
> I'm not sure if we want this to be always enabled or not, so sending
> this as an RFC. I can see definite advantages to doing so, but I also
> dislike having too many components on the always-enable list.
>
> Since I'm ambivilent myself, including this patch so the community can
> decide.
I don't think real applications use this.
If they do, they can include it manually.
My main objection is:
We are setting the wrong precedence if we make stuff like this mandatory for convenience.
But I agree with the reason you are suggesting it.
Is there some other way it can be enabled for unit tests?
Maybe the null driver can depend on the unit tests being built?
I don't mind that the driver is being built.
I just don't want it included by default when statically linking a monolithic application.
I'm flexible on this RFC, so it's a very soft NAK from me.
If it can be disabled at build time, I'm OK with it. (But still concerned about setting the wrong precedence.)
> ---
> drivers/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/meson.build b/drivers/meson.build
> index 3fe3be48fb..9ed0dba786 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -80,6 +80,8 @@ endif
> always_enable = ['bus/pci', 'bus/vdev']
> # we always need a mempool driver, and ring is default, so make it
> mandatory
> always_enable += ['mempool/ring']
> +# unit tests take advantage of net/null driver, so always enable it
> +always_enable += ['net/null']
> enable_drivers += always_enable
>
> default_cflags = machine_args
> --
> 2.51.0
next prev parent reply other threads:[~2026-01-22 13:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 12:23 [PATCH 0/3] manage net/null dependency for tests Bruce Richardson
2026-01-22 12:23 ` [PATCH 1/3] test/bpf: skip some testing if null net driver not present Bruce Richardson
2026-01-22 16:19 ` Stephen Hemminger
2026-01-22 16:23 ` Bruce Richardson
2026-01-22 22:17 ` [PATCH] test/bpf: skip the BPF ELF load tests if net null missing Stephen Hemminger
2026-01-23 7:55 ` Morten Brørup
2026-02-16 14:58 ` David Marchand
2026-01-22 12:23 ` [PATCH 2/3] test: fix missing dependency on null networking driver Bruce Richardson
2026-01-22 12:23 ` [PATCH 3/3] drivers: always enable the null net driver [RFC] Bruce Richardson
2026-01-22 13:13 ` Morten Brørup [this message]
2026-01-22 13:31 ` Bruce Richardson
2026-01-22 13:40 ` Morten Brørup
2026-01-22 14:59 ` Bruce Richardson
2026-01-22 16:09 ` Stephen Hemminger
2026-01-22 13:47 ` David Marchand
2026-01-22 14:57 ` Bruce Richardson
2026-01-22 15:37 ` Morten Brørup
2026-02-19 17:39 ` [PATCH v2 0/4] improve net/null dependency handling for tests Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 1/4] test/event_eth_rx_adapter: skip tests if no ethdevs Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 2/4] test/event_eth_tx_adapter: remove dependency on NULL PMD Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 3/4] test: fix missing dependency on null networking driver Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 4/4] build/tests: add warning for missing NULL PMD dependency Bruce Richardson
2026-02-19 19:44 ` [PATCH v2 0/4] improve net/null dependency handling for tests Morten Brørup
2026-03-03 16:29 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F6568E@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox