public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: RE: [PATCH] test/bpf: skip the BPF ELF load tests if net null missing
Date: Fri, 23 Jan 2026 08:55:09 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65693@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260122221728.231962-1-stephen@networkplumber.org>

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 22 January 2026 23.17
> 
> The BPF filtering tests need NULL PMD vdev to work.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

With or without suggested change,
Acked-by: Morten Brørup <mb@smartsharesystems.com>

> ---
>  app/test/test_bpf.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
> index 0e969f9f13..78998c6194 100644
> --- a/app/test/test_bpf.c
> +++ b/app/test/test_bpf.c
> @@ -3280,7 +3280,15 @@ test_bpf(void)
> 
>  REGISTER_FAST_TEST(bpf_autotest, NOHUGE_OK, ASAN_OK, test_bpf);
> 
> -#ifdef TEST_BPF_ELF_LOAD
> +/*
> + * The BPF elf load tests needs the BPF programs to be successfully
> + * compiled into generated file bpf_test.h. This means having
> + * clang with BPF target and xxd command to encode object.
> + *
> + * Test also needs the NULL PMD to be able to have something
> + * to insert filter onto.
> + */
> +#if defined(RTE_NET_NULL) && defined(TEST_BPF_ELF_LOAD)

nit:
Consider swapping the order:
#if defined(TEST_BPF_ELF_LOAD) && defined(RTE_NET_NULL)

> 
>  /*
>   * Helper function to write BPF object data to temporary file.
> @@ -3746,11 +3754,11 @@ test_bpf_elf(void)
>  static int
>  test_bpf_elf(void)
>  {
> -	printf("BPF compile not supported, skipping test\n");
> +	printf("BPF compile or NULL PMD not supported, skipping test\n");
>  	return TEST_SKIPPED;
>  }
> 
> -#endif /* !TEST_BPF_ELF_LOAD */
> +#endif /* !(TEST_BPF_ELF_LOAD && RTE_NULL) */
> 
>  REGISTER_FAST_TEST(bpf_elf_autotest, NOHUGE_OK, ASAN_OK,
> test_bpf_elf);
> 
> --
> 2.51.0


  reply	other threads:[~2026-01-23  7:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 12:23 [PATCH 0/3] manage net/null dependency for tests Bruce Richardson
2026-01-22 12:23 ` [PATCH 1/3] test/bpf: skip some testing if null net driver not present Bruce Richardson
2026-01-22 16:19   ` Stephen Hemminger
2026-01-22 16:23     ` Bruce Richardson
2026-01-22 22:17   ` [PATCH] test/bpf: skip the BPF ELF load tests if net null missing Stephen Hemminger
2026-01-23  7:55     ` Morten Brørup [this message]
2026-02-16 14:58     ` David Marchand
2026-01-22 12:23 ` [PATCH 2/3] test: fix missing dependency on null networking driver Bruce Richardson
2026-01-22 12:23 ` [PATCH 3/3] drivers: always enable the null net driver [RFC] Bruce Richardson
2026-01-22 13:13   ` Morten Brørup
2026-01-22 13:31     ` Bruce Richardson
2026-01-22 13:40       ` Morten Brørup
2026-01-22 14:59         ` Bruce Richardson
2026-01-22 16:09           ` Stephen Hemminger
2026-01-22 13:47       ` David Marchand
2026-01-22 14:57         ` Bruce Richardson
2026-01-22 15:37           ` Morten Brørup
2026-02-19 17:39 ` [PATCH v2 0/4] improve net/null dependency handling for tests Bruce Richardson
2026-02-19 17:39   ` [PATCH v2 1/4] test/event_eth_rx_adapter: skip tests if no ethdevs Bruce Richardson
2026-02-19 17:39   ` [PATCH v2 2/4] test/event_eth_tx_adapter: remove dependency on NULL PMD Bruce Richardson
2026-02-19 17:39   ` [PATCH v2 3/4] test: fix missing dependency on null networking driver Bruce Richardson
2026-02-19 17:39   ` [PATCH v2 4/4] build/tests: add warning for missing NULL PMD dependency Bruce Richardson
2026-02-19 19:44   ` [PATCH v2 0/4] improve net/null dependency handling for tests Morten Brørup
2026-03-03 16:29   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65693@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox