public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>
Subject: RE: [PATCH] mempool: introduce statistics reset function
Date: Tue, 24 Feb 2026 07:38:32 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65740@smartserver.smartshare.dk> (raw)
In-Reply-To: <6af4bdb3-0a0c-4d99-9852-376bf93d1a16@oktetlabs.ru>

> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
> Sent: Tuesday, 24 February 2026 07.29
> 
> On 2/23/26 1:20 PM, Morten Brørup wrote:
> > Populating a mempool with objects is accounted for in the statistics.
> > When analyzing mempool cache statistics, this may distort the data.
> > In order to simplify mempool cache statistics analysis, a mempool
> > statistics reset function was added.
> >
> > Furthermore, details about average burst sizes and mempool cache miss
> > rates were added to the statistics shown when dumping a mempool.
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> 
> I'd like to see thoughts about consistency after reset taking into
> account that reset will likely to be done from control core whereas
> stats are updated from data cores. Results could be very interesting.
> I guess it is not the reason to introduce locking or any other kind
> of synchronization, but user should be warned as the bare minimum.

When used for cache statistics analysis, the reset function will be called once only: After everything has been initialized (mempool created and populated, and ethdev Rx queues preloaded with mbufs), but before the data plane is started.

I don't think the end user should be warned; this may be normal behavior for an application.
In addition to the trace event, I'll add a DEBUG level log message in the function.

And a warning about potential inconsistency in the function description.

Good feedback, Andrew!


  reply	other threads:[~2026-02-24  6:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 10:20 [PATCH] mempool: introduce statistics reset function Morten Brørup
2026-02-23 17:21 ` Stephen Hemminger
2026-02-23 18:14   ` Morten Brørup
2026-02-24  6:29 ` Andrew Rybchenko
2026-02-24  6:38   ` Morten Brørup [this message]
2026-02-24  6:50     ` Andrew Rybchenko
2026-02-24  9:28 ` [PATCH v2] " Morten Brørup
2026-02-24  9:57   ` Andrew Rybchenko
2026-02-27  9:20   ` fengchengwen
2026-02-27 21:24     ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65740@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox