From: "Morten Brørup" <mb@smartsharesystems.com>
To: "fengchengwen" <fengchengwen@huawei.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Cc: <techboard@dpdk.org>
Subject: RE: [PATCH v2] mempool: introduce statistics reset function
Date: Fri, 27 Feb 2026 22:24:00 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65757@smartserver.smartshare.dk> (raw)
In-Reply-To: <78c276d7-6d80-408c-a1f2-a92f1a89a9ea@huawei.com>
> From: fengchengwen [mailto:fengchengwen@huawei.com]
> Sent: Friday, 27 February 2026 10.20
>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
> Another question:
> How about the overload of mempool stats, If the cost is low, can we
> remove the debug macro? As far as I know, some DPDK applications
> enable
> mempool statistics (maybe self-impl) in the production environment,
> which is mainly used to help locate problems.
Mempool is a core library, so even though the overhead of the mempool statistics is relatively low cost, it is a debug-only facility, and the extra overhead should be not be forced upon users.
IMO, we should keep it build time configurable.
You do raise a good point about the balance tradeoff!
Maybe enabling it for production is worth it for the majority of users. In SmartShare Systems, we enable it for production too.
We should discuss changing the default from disabled to enabled.
prev parent reply other threads:[~2026-02-27 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 10:20 [PATCH] mempool: introduce statistics reset function Morten Brørup
2026-02-23 17:21 ` Stephen Hemminger
2026-02-23 18:14 ` Morten Brørup
2026-02-24 6:29 ` Andrew Rybchenko
2026-02-24 6:38 ` Morten Brørup
2026-02-24 6:50 ` Andrew Rybchenko
2026-02-24 9:28 ` [PATCH v2] " Morten Brørup
2026-02-24 9:57 ` Andrew Rybchenko
2026-02-27 9:20 ` fengchengwen
2026-02-27 21:24 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65757@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox