From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
"David Marchand" <david.marchand@redhat.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>,
"Robin Jarry" <rjarry@redhat.com>, <dev@dpdk.org>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: RE: [RFC v2 5/5] eal: configure initial device probing
Date: Mon, 2 Mar 2026 12:08:16 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F6575B@smartserver.smartshare.dk> (raw)
In-Reply-To: <aaVSHYANsEFRx-oQ@bricha3-mobl1.ger.corp.intel.com>
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Monday, 2 March 2026 10.02
>
> On Fri, Feb 27, 2026 at 02:10:45PM -0800, Stephen Hemminger wrote:
> > On Fri, 27 Feb 2026 13:51:48 +0000
> > Bruce Richardson <bruce.richardson@intel.com> wrote:
> >
> > > On Fri, Feb 27, 2026 at 02:43:46PM +0100, Thomas Monjalon wrote:
> > > > 26/02/2026 17:50, Robin Jarry:
> > > > > David Marchand, Feb 26, 2026 at 17:20:
> > > > > > Some applications use port hotplug as their primary way for
> using DPDK
> > > > > > resources.
> > > > > > Having a systematic device probing is a problem when not all
> available
> > > > > > resources will be used by the application, as such
> applications won't set
> > > > > > an explicit allow list at startup.
> > > > > >
> > > > > > This is the case for OVS on systems with multiple mlx5
> devices:
> > > > > > one device can be used by the kernel while the other(s) are
> used by DPDK.
> > > > > > In such a setup, the kernel used device may get reconfigured
> in
> > > > > > unexpected ways and trigger issues like the one described by
> Kevin
> > > > > > not so long ago in bugzilla 1873.
> > > > > >
> > > > > > Add an EAL option so that we can change the default behavior
> from
> > > > > > block-listing to allow-listing.
> > > > [...]
> > > > > > + const char * const argv29[] = {prgname, prefix, mp_flag,
> eal_debug_logs,
> > > > > > + "--allow-explicitly" };
> > > > >
> > > > > I am not convinced by the option name. What do you think of:
> > > > >
> > > > > --no-autoprobe
> > > > >
> > > > > That would match the Linux sriov_drivers_autoprobe sysfs.
> > > >
> > > > The name --no-autoprobe is better indeed.
> > > >
> > > > The exact effect of this option is to disable initial probing
> > > > of devices on all buses (except vdev).
> > > > Another name could be --no-initial-probing
> > > >
> > > > I think we should add the opposite option as well
> > > > to allow changing the default mode later.
> > > > For such an option, --autoprobe looks better than --initial-
> probing.
> > > >
> > > > Other opinions?
> > > >
> > > >
> > > > [...]
> > > > > Depending on what option name we settle on, could you add a
> short flag
> > > > > too? E.g.:
> > > > >
> > > > > BOOL_ARG("--no-autoprobe", "-N", "Disable automatic probing of
> non-blocked devices", no_autoprobe)
> > > > >
> > > > > Or:
> > > > >
> > > > > BOOL_ARG("--no-autoprobe", "-P", "Disable automatic probing of
> non-blocked devices", no_autoprobe)
> > > >
> > > > I don't see the benefit of a short flag.
> > > > It makes reading commands less obvious.
> > > >
> > > I actually would prefer to have a short option available, and I'd
> really
> > > like that short option to be "-A" since it serves as the perfect
> addition
> > > to the "-a" flag to specify devices to probe.
> > >
> > > Based on that, I would look for long options which allow "-A" as
> the short
> > > version for example:
> > >
> > > --allowlisted-devs-only
> > >
> > > /Bruce
> >
> > Also if -b or --block-list become a no op with --no-autoprobe. So it
> should be a warning?
>
> Yes, I think a warning about ignored parameter would be appropriate.
>
> /Bruce
I haven't been following this discussion, so I might me completely off here.
IIUC, this option is used for specifying which devices to probe.
(And as a side effect disables auto-probing of all devices.)
When naming it, please take a fresh view.
Imagine you are defining this option and an auto-probe option.
The discussion assumes the user is familiar with auto-probe, and expects auto-probe. Don't design based on that.
-Morten
next prev parent reply other threads:[~2026-03-02 11:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 11:29 [RFC 1/2] devtools: check packet forwarding in null test David Marchand
2026-02-25 11:29 ` [RFC 2/2] eal: configure initial device probing David Marchand
2026-02-25 12:09 ` Bruce Richardson
2026-02-25 17:53 ` David Marchand
2026-02-26 16:20 ` [RFC v2 0/5] Rework " David Marchand
2026-02-26 16:20 ` [RFC v2 1/5] devtools: check packet forwarding in null test David Marchand
2026-02-26 16:35 ` Bruce Richardson
2026-02-26 16:20 ` [RFC v2 2/5] bus/fslmc: fix bus cleanup David Marchand
2026-02-26 16:20 ` [RFC v2 3/5] drivers/bus: require probe function for NXP drivers David Marchand
2026-02-26 16:24 ` Bruce Richardson
2026-02-26 16:20 ` [RFC v2 4/5] bus: factorize device selection David Marchand
2026-02-26 16:31 ` Bruce Richardson
2026-02-27 14:17 ` David Marchand
2026-02-27 14:33 ` Bruce Richardson
2026-02-26 16:20 ` [RFC v2 5/5] eal: configure initial device probing David Marchand
2026-02-26 16:34 ` Bruce Richardson
2026-02-26 16:50 ` Robin Jarry
2026-02-27 13:43 ` Thomas Monjalon
2026-02-27 13:51 ` Bruce Richardson
2026-02-27 22:10 ` Stephen Hemminger
2026-03-02 9:02 ` Bruce Richardson
2026-03-02 11:08 ` Morten Brørup [this message]
2026-03-02 11:13 ` David Marchand
2026-03-05 16:45 ` [RFC v3 0/7] Rework " David Marchand
2026-03-05 16:45 ` [RFC v3 1/7] devtools: check packet forwarding in null test David Marchand
2026-03-05 16:45 ` [RFC v3 2/7] bus/fslmc: fix bus cleanup David Marchand
2026-03-05 16:45 ` [RFC v3 3/7] drivers/bus: require probe function for NXP drivers David Marchand
2026-03-05 16:45 ` [RFC v3 4/7] drivers: cleanup devargs lookup in bus scan David Marchand
2026-03-05 16:56 ` Bruce Richardson
2026-03-05 16:45 ` [RFC v3 5/7] bus: factorize devargs lookup David Marchand
2026-03-05 17:06 ` Bruce Richardson
2026-03-05 17:10 ` David Marchand
2026-03-05 16:45 ` [RFC v3 6/7] bus: factorize device selection David Marchand
2026-03-05 17:30 ` Bruce Richardson
2026-03-09 9:50 ` David Marchand
2026-03-07 20:59 ` Robin Jarry
2026-03-05 16:45 ` [RFC v3 7/7] eal: configure initial device probing David Marchand
2026-03-05 17:33 ` Bruce Richardson
2026-03-07 21:05 ` Robin Jarry
2026-03-06 8:26 ` [RFC v3 0/7] Rework " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F6575B@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox