DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <ciara.loftus@intel.com>
Subject: RE: [PATCH v4 0/2] net/intel: optimize for fast-free hint
Date: Tue, 2 Jun 2026 18:26:13 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F658DD@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260602154513.1079865-1-bruce.richardson@intel.com>

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Tuesday, 2 June 2026 17.45
> 
> When the fast-free hint is provided to the driver we know that the
> mbufs
> have refcnt of 1 and are from the same mempool. Therefore, we can
> optimize a bit for this case even in the scalar path of our drivers.
> 
> ---
> v4:
> * add precursor patch to adjust mbuf pointers so that the DD bit
>   is written to a descriptor with a valid mbuf pointer associated
>   with it.
> 
> v3:
> * used mbuf_raw_free_bulk rather than mempool function directly
> * check for fast_free via mp pointer rather than flags
> * remove unnecessary prefetches
> 
> V2: Fix issues with original submission:
> * missed check for NULL mbufs
> * fixed issue with freeing directly from sw_ring in scalar path which
>   doesn't work as thats not a flag array of pointers
> * fixed missing null assignment in case of large segments for TSO
> 
> 
> Bruce Richardson (2):
>   net/intel: write mbuf for last Tx desc of segment
>   net/intel: optimize for fast-free hint
> 
>  drivers/net/intel/common/tx.h        | 21 ++++--
>  drivers/net/intel/common/tx_scalar.h | 98 +++++++++++++++++++++-------
>  2 files changed, 90 insertions(+), 29 deletions(-)
> 
> --
> 2.53.0

Good catch by Ciara, and good solution to it.
Series-Acked-by: Morten Brørup <mb@smartsharesystems.com>


  parent reply	other threads:[~2026-06-02 16:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 11:06 mbuf fast-free requirements analysis Morten Brørup
2025-12-15 11:46 ` Bruce Richardson
2026-01-14 15:31   ` Morten Brørup
2026-01-14 16:36     ` Bruce Richardson
2026-01-14 18:05       ` Morten Brørup
2026-01-15  8:46         ` Bruce Richardson
2026-01-15  9:04           ` Morten Brørup
2026-01-23 11:20     ` [PATCH] net/intel: optimize for fast-free hint Bruce Richardson
2026-01-23 12:05       ` Morten Brørup
2026-01-23 12:09         ` Bruce Richardson
2026-01-23 12:27           ` Morten Brørup
2026-01-23 12:53             ` Bruce Richardson
2026-01-23 13:06               ` Morten Brørup
2026-04-08 13:25       ` [PATCH v2] " Bruce Richardson
2026-04-08 19:27         ` Morten Brørup
2026-05-19 11:01           ` Bruce Richardson
2026-05-19 11:06       ` [PATCH v3] " Bruce Richardson
2026-05-28 13:23         ` Loftus, Ciara
2026-06-02 15:36           ` Bruce Richardson
2026-06-02 15:45       ` [PATCH v4 0/2] " Bruce Richardson
2026-06-02 15:45         ` [PATCH v4 1/2] net/intel: write mbuf for last Tx desc of segment Bruce Richardson
2026-06-03 14:21           ` Loftus, Ciara
2026-06-02 15:45         ` [PATCH v4 2/2] net/intel: optimize for fast-free hint Bruce Richardson
2026-06-02 16:26         ` Morten Brørup [this message]
2026-06-03 15:56           ` [PATCH v4 0/2] " Bruce Richardson
2026-01-23 11:33     ` mbuf fast-free requirements analysis Bruce Richardson
2025-12-15 14:41 ` Konstantin Ananyev
2025-12-15 16:14   ` Morten Brørup
2025-12-19 17:08     ` Konstantin Ananyev
2025-12-20  7:33       ` Morten Brørup
2025-12-22 15:22         ` Konstantin Ananyev
2025-12-22 17:11           ` Morten Brørup
2025-12-22 17:43             ` Bruce Richardson
2026-01-13 14:48               ` Konstantin Ananyev
2026-01-13 16:07                 ` Stephen Hemminger
2026-01-14 17:01 ` Bruce Richardson
2026-01-14 17:31   ` Morten Brørup
2026-01-14 17:45     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F658DD@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox