DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: <datshan@qq.com>, <thomas@monjalon.net>, <stephen@networkplumber.org>
Cc: <aconole@redhat.com>, <dev@dpdk.org>
Subject: RE: [PATCH v3] devtools: support local opencode agent for patch review
Date: Tue, 4 Aug 2026 14:22:47 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F659B6@smartserver.smartshare.dk> (raw)
In-Reply-To: <tencent_CFE5ECAF36405DFD2FB29DB7319B04E72C08@qq.com>

> From: datshan@qq.com [mailto:datshan@qq.com]
> Sent: Saturday, 25 July 2026 10.44
> From: Chengwen Feng <fengchengwen@huawei.com>
> 
> Currently review-patch.py only supports cloud AI providers
> (Anthropic, OpenAI, xAI, Google) via REST API, requiring API keys.
> 
> Add a --via option that invokes the locally installed opencode CLI as
> the review runner instead of making HTTP calls. opencode reads
> AGENTS.md from the DPDK project directory automatically, needing no
> configuration beyond opencode on PATH.
> 
> The --via and -p/--provider options are independent -- via routes to
> the local agent mode while -p continues to use the cloud API path.
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> 
> ---
> v3: Rebase main to fix apply error
> v2: Address comments from Stephen, including: not arise
> FileNotFoundError and more clarify.
> ---

I have only skimmed this, but
the concept of local agent support deserves a big fat:
Acked-by: Morten Brørup <mb@smartsharesystems.com>


  parent reply	other threads:[~2026-08-04 12:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260703091902.525837-1-datshan@qq.com>
2026-07-06  6:29 ` [PATCH v2] devtools: support local opencode agent for patch review datshan
2026-07-25  8:43 ` [PATCH v3] " datshan
2026-08-04  8:41   ` fengchengwen
2026-08-04 12:22   ` Morten Brørup [this message]
2026-08-04 16:18   ` Stephen Hemminger
2026-08-05  6:12 ` [PATCH v4] " datshan
2026-08-07  3:11 ` [PATCH v5] " Chengwen Feng
2026-08-07  3:32   ` fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F659B6@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=aconole@redhat.com \
    --cc=datshan@qq.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox