DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Konstantin Ananyev" <konstantin.ananyev@huawei.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, "Bruce Richardson" <bruce.richardson@intel.com>
Subject: RE: [PATCH] eal/x86: optimize memcpy of small 64-byte blocks
Date: Wed, 5 Aug 2026 07:56:13 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F659BD@smartserver.smartshare.dk> (raw)
In-Reply-To: <6f474724bc22441a8a4f516f3398ca76@huawei.com>

> From: Konstantin Ananyev [mailto:konstantin.ananyev@huawei.com]
> Sent: Wednesday, 5 August 2026 07.46
> 
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > Sent: Tuesday, 4 August 2026 17.52
> > >
> > > On Tue,  4 Aug 2026 14:33:04 +0000
> > > Morten Brørup <mb@smartsharesystems.com> wrote:
> > >
> > > > +	/* Common way for small copy size of 64-byte blocks.
> Unlikely, so
> > > constant size only */
> > > > +	if (__rte_constant(n) && (n & 63) == 0 && n <=
> > > RTE_MEMCPY_BLOCK_64_MAX) {
> > > > +		void *ret = dst;
> > > > +
> > >
> > > Maybe just let compiler decide, it will generate vector
> instructions in
> > > most cases.
> > >
> > > 	if (__rte_constant(n))
> > > 		return mempcpy(dst, src, n);
> >
> > Maybe in most, but not in all:
> > https://godbolt.org/z/KvdKqT5rY
> 
> With '-mavx' or '-mavx512f' it looks like it does for your sample code.

It also does with -msse4.2 when SZ is reduced to 256 bytes.
Clang switches to inline when SZ is reduced to 128 bytes.

It seems the compiler has a threshold for when to inline and when to call the C library's memcpy subroutine.
The threshold depends on both copy size and vector register size.
And it is compiler dependent.

With rte_memcpy() it is always inline.


  reply	other threads:[~2026-08-05  5:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 14:33 [PATCH] eal/x86: optimize memcpy of small 64-byte blocks Morten Brørup
2026-08-04 14:33 ` [RFC PATCH] pile stack and mempool driver (resend) Morten Brørup
2026-08-04 14:38   ` Morten Brørup
2026-08-04 15:52 ` [PATCH] eal/x86: optimize memcpy of small 64-byte blocks Stephen Hemminger
2026-08-04 16:25   ` Morten Brørup
2026-08-05  5:45     ` Konstantin Ananyev
2026-08-05  5:56       ` Morten Brørup [this message]
2026-08-05  6:50         ` Konstantin Ananyev
2026-08-05  8:36           ` Morten Brørup
2026-08-04 19:11 ` Morten Brørup
2026-08-04 20:42   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F659BD@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox