From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B25CC5CFEB for ; Thu, 13 Aug 2026 12:56:55 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98E5E402AC; Thu, 13 Aug 2026 14:56:54 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 16D5E40298 for ; Thu, 13 Aug 2026 14:56:53 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id E14EC206E1; Thu, 13 Aug 2026 14:56:52 +0200 (CEST) Content-class: urn:content-classes:message Subject: RE: [RFC PATCH v2] mempool: optimizations MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Aug 2026 14:56:50 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F659E0@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [RFC PATCH v2] mempool: optimizations Thread-Index: Ad0rGs6PbZF0D2AOTsSelZu3GcQXuAABOOjQ References: <20260812090723.1771628-1-mb@smartsharesystems.com> <20260812120626.1772120-1-mb@smartsharesystems.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" Cc: , "Andrew Rybchenko" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > +* mempool: The obsolete ``flushthresh`` field was removed from the > > ``rte_mempool_cache`` structure. + * Removed deprecated symbols: > > > I'm not convinced about removing this field at this point. Based on > previous discussions around run-to-completion vs pipeline apps, and = the > reported performance degradations due to recent cache changes, I could > see a scenario where it's useful to track a separate flushthreshold or > cache-keep threshold for a mempool. Removing the flushthresh field is part of the cleanup patch [1]. I merged that patch into this one because I'm having problems with = Depends-on. We all agree that different use cases benefit from different algorithms. And the 26.07 update switches the favor towards run-to-completion use = cases over get-put-on-separate-lcores use cases. If we sometime in the future change the cache algorithm or amend it, and = need another field in the cache structure, we can add a new field with a = name reflecting its function, rather than reusing the flushthresh field = for another purpose. A new algorithm might even need more than one = field. The flushthresh field is obsolete, and should be removed. This was also = mentioned in the deprecation notice for DPDK 26.07. [1]: = https://patchwork.dpdk.org/project/dpdk/patch/20260806154506.1532375-1-mb= @smartsharesystems.com/ PS: The performance degradations were mainly due to the effective cache size = being reduced from 150 % to 100 %. Testers confirmed on the mailing list that the performance degradation = went away when recompiling with a 150 % larger cache, so the effective = cache size was unchanged.