From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Nam Tran" <hoangnamtran18122005@gmail.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: RE: [PATCH v2] mbuf: avoid temporary array for bulk free
Date: Tue, 29 Sep 2026 06:39:21 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65A84@smartserver.smartshare.dk> (raw)
In-Reply-To: <20260929002527.7-1-hoangnamtran18122005@gmail.com>
> v2:
> - Cap same-pool runs at 64 to retain mempool-cache behavior.
NAK!
Why would you do that?
> - Move the sanity check after the chained-packet fallback decision.
> - Add mixed flat/chained and indirect-mbuf regression cases.
> - Remove the earlier timing claim; the capped version has not yet
> been benchmarked on x86 or with a cached mempool.
>
> + run_count++;
> + if (run_count == RTE_PKTMBUF_FREE_PENDING_SZ) {
> + rte_mbuf_raw_free_bulk(run_pool,
> + &mbufs[run_start], run_count);
> + run_count = 0;
> + }
NAK to this part.
Flushing a large bulk in smaller bulks of 64 mbufs is not necessary, and may reduce performance.
next prev parent reply other threads:[~2026-09-29 4:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 1:28 [PATCH] mbuf: avoid temporary array for bulk free Nam Tran
2026-09-22 10:59 ` Morten Brørup
2026-09-22 13:54 ` Stephen Hemminger
2026-09-29 0:25 ` [PATCH v2] " Nam Tran
2026-09-29 4:39 ` Morten Brørup [this message]
2026-10-05 6:47 ` [EXTERNAL] " Ashwin Sekhar
2026-10-05 7:45 ` Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65A84@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=hoangnamtran18122005@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox