From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Robert Sanford" <rsanford2@gmail.com>, <dev@dpdk.org>
Cc: <andrew.rybchenko@oktetlabs.ru>, <olivier.matz@6wind.com>,
<stable@dpdk.org>, <rsanford@akamai.com>
Subject: RE: [PATCH v2 2/3] mempool: fix dump of unpopulated pool
Date: Fri, 6 Nov 2026 20:24:02 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35F65AFF@smartserver.smartshare.dk> (raw)
In-Reply-To: <20261106184329.2095115-1-rsanford2@gmail.com>
> From: Robert Sanford [mailto:rsanford2@gmail.com]
> Sent: Friday, 6 November 2026 19.43
>
> Hi Morten,
>
> Thanks for the review.
>
> > mempool_is_created() should be public as rte_mempool_is_created().
>
> I made the change: rte_mempool_is_created() is public, non-inline,
> not experimental, and the rte_mempool_walk() description refers to it.
>
> However, devtools/check-symbol-change.py reports:
>
> ERROR: rte_mempool_is_created in lib/mempool has been added directly
> to stable ABI.
>
> How would you like me to proceed?
Please ignore the error, and send the series anyway.
Patch acceptance is a manual process, and we can ignore errors like this, when relevant.
I consider the alternative, an experimental public function, and a private function doing exactly the same (or copy-pasted code to atomically check the "created" flag), an ugly hack.
-Morten
next prev parent reply other threads:[~2026-11-06 19:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 1:11 [PATCH v1 0/3] mempool: fix races between list walk and create/free Robert Sanford
2026-11-03 1:11 ` [PATCH v1 1/3] mempool: fix race between list walk and free Robert Sanford
2026-11-03 13:54 ` Morten Brørup
2026-11-03 1:11 ` [PATCH v1 2/3] mempool: skip unpopulated pools in walk and dump Robert Sanford
2026-11-03 14:12 ` Morten Brørup
2026-11-03 1:11 ` [PATCH v1 3/3] test/mempool: add list walk race test Robert Sanford
2026-11-03 14:15 ` Morten Brørup
2026-11-03 17:35 ` [PATCH v2 0/3] mempool: fix races between list walk and create/free Robert Sanford
2026-11-03 17:35 ` [PATCH v2 1/3] mempool: fix race between list walk and free Robert Sanford
2026-11-03 17:35 ` [PATCH v2 2/3] mempool: fix dump of unpopulated pool Robert Sanford
2026-11-06 8:43 ` Morten Brørup
2026-11-06 18:43 ` Robert Sanford
2026-11-06 19:24 ` Morten Brørup [this message]
2026-11-03 17:35 ` [PATCH v2 3/3] test/mempool: add list walk race test Robert Sanford
2026-11-09 14:40 ` [PATCH v3 0/3] mempool: fix races between list walk and create/free Robert Sanford
2026-11-09 14:40 ` [PATCH v3 1/3] mempool: fix race between list walk and free Robert Sanford
2026-11-09 14:40 ` [PATCH v3 2/3] mempool: fix dump of unpopulated pool Robert Sanford
2026-11-09 14:40 ` [PATCH v3 3/3] test/mempool: add list walk race test Robert Sanford
2026-11-11 13:00 ` Morten Brørup
2026-11-12 15:43 ` [PATCH v4 0/3] mempool: fix races between list walk and create/free Robert Sanford
2026-11-12 15:43 ` [PATCH v4 1/3] mempool: fix race between list walk and free Robert Sanford
2026-11-12 15:43 ` [PATCH v4 2/3] mempool: fix dump of unpopulated pool Robert Sanford
2026-11-12 15:43 ` [PATCH v4 3/3] test/mempool: add list walk race test Robert Sanford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35F65AFF@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=rsanford2@gmail.com \
--cc=rsanford@akamai.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox