From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH v2] mempool: rename functions with confusing names Date: Thu, 30 Jun 2016 15:02:22 +0300 Message-ID: <98f41037-a666-53b6-efce-65a73a218d29@redhat.com> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467217635-19766-1-git-send-email-bruce.richardson@intel.com> <1585831.LcblvschXd@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com To: Thomas Monjalon , Bruce Richardson Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 823D32617 for ; Thu, 30 Jun 2016 14:02:25 +0200 (CEST) In-Reply-To: <1585831.LcblvschXd@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count > > This patch needs to be rebased please. > >> --- a/lib/librte_mempool/rte_mempool_version.map >> +++ b/lib/librte_mempool/rte_mempool_version.map >> @@ -32,5 +32,6 @@ DPDK_16.07 { >> rte_mempool_populate_virt; >> rte_mempool_register_ops; >> rte_mempool_set_ops_byname; >> + rte_mempool_avail_count; > > The "in_use_count" function is missing. Its missing because the function is static inline. If you ask me, this would be as fine time as any to remove that inlining ;) - Panu - > Please keep alphabetical order. >