From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH v2 5/7] net/virtio_user: add vhost kernel support Date: Fri, 13 Jan 2017 10:27:27 +0800 Message-ID: <99b5b244-07e4-16f1-953d-3e4a5f24a746@redhat.com> References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com> <1482477266-39199-6-git-send-email-jianfeng.tan@intel.com> <46af618f-c01b-3571-78fc-12d10859a4a1@redhat.com> <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com> <83c1bc3a-7b16-6f73-f0ba-6ed5c863eaa5@redhat.com> <5129c726-30fa-d4ed-a0c0-5b811772a6fb@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com, cunming.liang@intel.com To: "Tan, Jianfeng" , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D400E5588 for ; Fri, 13 Jan 2017 03:27:36 +0100 (CET) In-Reply-To: <5129c726-30fa-d4ed-a0c0-5b811772a6fb@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2017年01月12日 17:40, Tan, Jianfeng wrote: > Hi Jason, > >> Ok, just want to show its advantages. It can be added on top. >> >> And two more suggestions: >> - better to split tap support out of vhost file > > Good suggestion! Will do that in next version. > >> - kernel support more than 8 queues on recent kernel, so there's no >> need to limit it to 8. When running on old kernel, TUNSETIFF will >> fail which can give user a hint to reduce #queues. >> > > After a try, even we remove such restriction in vhost_kernel backend, > we are still restricted by VIRTIO_MAX_VIRTQUEUES (8) defined in virtio > PMD. I think we'd better remove this limitation in the future. Thanks > > Thanks for the suggestions! > > Jianfeng