From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 1/3] app/testpmd: move dumping packets to
 a separate function
Date: Wed, 17 Oct 2018 13:27:42 +0100
Message-ID: <9a5d7932-471e-57cb-7311-2224888bfdcb@intel.com>
References: <1538897848-1693-1-git-send-email-rasland@mellanox.com>
 <1539761251-7677-1-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: thomas@monjalon.net, dev@dpdk.org, shahafs@mellanox.com,
 xuemingl@mellanox.com, orika@mellanox.com, jerin.jacob@caviumnetworks.com,
 david.marchand@6wind.com, bernard.iremonger@intel.com
To: Raslan Darawsheh <rasland@mellanox.com>, jingjing.wu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 827924F94
 for <dev@dpdk.org>; Wed, 17 Oct 2018 14:27:46 +0200 (CEST)
In-Reply-To: <1539761251-7677-1-git-send-email-rasland@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/17/2018 8:27 AM, Raslan Darawsheh wrote:
> verbosity for the received/sent packets is needed in all of the
> forwarding engines so moving it to be in a separate function
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>

<...>

> +static  inline void
> +dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> +	      uint16_t nb_pkts, int is_rx)
> +{

This is causing build error when only this patch applied:

.../app/test-pmd/util.c:25:1: error: unused function 'dump_pkt_burst'
[-Werror,-Wunused-function]
dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
^